[bug #28446] No checks are made for unteminated strings in RPC messages

Follow-up Comment #1, bug #28446 (project hurd): The client-side dir_lookup function generated by MIG calls __mig_strncpy(InP->file_name, file_name, 1024) to copy the file name to the request message. If the file name is too long, this silently truncates it and does not append a null character.

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Sat, Jan 09, 2010 at 07:10:30PM +0100, olafbuddenha...@gmx.net wrote: > On Thu, Jan 07, 2010 at 04:45:57PM +0100, Carl Fredrik Hammar wrote: > > On Mon, Jan 04, 2010 at 03:34:07PM +0100, olafbuddenha...@gmx.net > > wrote: > > > On a technical side, you have to decide what error code MiG sho

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Thu, Jan 07, 2010 at 04:45:57PM +0100, Carl Fredrik Hammar wrote: > On Mon, Jan 04, 2010 at 03:34:07PM +0100, olafbuddenha...@gmx.net > wrote: > > On Sun, Jan 03, 2010 at 09:40:43PM +0100, Carl Fredrik Hammar wrote: > > > I still don't see how changing MIG is invasive... > > > > As I said

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Mon, Jan 04, 2010 at 03:34:07PM +0100, olafbuddenha...@gmx.net wrote: > On Sun, Jan 03, 2010 at 09:40:43PM +0100, Carl Fredrik Hammar wrote: > > I still don't see how changing MIG is invasive... > > As I said, it requires someone to say, "yes, this is the right thing to > do; please commit

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Sun, Jan 03, 2010 at 09:40:43PM +0100, Carl Fredrik Hammar wrote: > On Sun, Jan 03, 2010 at 11:42:52AM +0100, olafbuddenha...@gmx.net > wrote: > > But if Mach actually knows C strings, are you sure the kernel > > doesn't actually perform the check for 0-termination itself in the > > IPC co

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Sun, Jan 03, 2010 at 11:42:52AM +0100, olafbuddenha...@gmx.net wrote: > On Sat, Jan 02, 2010 at 12:11:38PM +0100, Carl Fredrik Hammar wrote: > > On Sat, Jan 02, 2010 at 08:12:17AM +0100, olafbuddenha...@gmx.net > > wrote: > > > On Fri, Jan 01, 2010 at 10:36:35PM +0100, Carl Fredrik Hammar w

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Sat, Jan 02, 2010 at 12:11:38PM +0100, Carl Fredrik Hammar wrote: > On Sat, Jan 02, 2010 at 08:12:17AM +0100, olafbuddenha...@gmx.net > wrote: > > On Fri, Jan 01, 2010 at 10:36:35PM +0100, Carl Fredrik Hammar wrote: > MIG does have a c_string type after all, which is used to define the > s

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Sat, Jan 02, 2010 at 08:12:17AM +0100, olafbuddenha...@gmx.net wrote: > On Fri, Jan 01, 2010 at 10:36:35PM +0100, Carl Fredrik Hammar wrote: > > On Thu, Dec 31, 2009 at 04:12:21AM +0100, olafbuddenha...@gmx.net wrote: > > > On Wed, Dec 30, 2009 at 07:42:21PM +, Carl Fredrik Hammar wrote

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Fri, Jan 01, 2010 at 10:36:35PM +0100, Carl Fredrik Hammar wrote: > On Thu, Dec 31, 2009 at 04:12:21AM +0100, olafbuddenha...@gmx.net wrote: > > On Wed, Dec 30, 2009 at 07:42:21PM +, Carl Fredrik Hammar wrote: > > > Strings in RPCs, such as the filename argument to a dir_lookup, are >

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Thu, Dec 31, 2009 at 04:12:21AM +0100, olafbuddenha...@gmx.net wrote: > On Wed, Dec 30, 2009 at 07:42:21PM +, Carl Fredrik Hammar wrote: > > > Strings in RPCs, such as the filename argument to a dir_lookup, are > > not checked if they are terminated by '\0'. This could lead to the > >

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

olafbuddenha...@gmx.net, le Thu 31 Dec 2009 04:12:21 +0100, a écrit : > On Wed, Dec 30, 2009 at 07:42:21PM +, Carl Fredrik Hammar wrote: > > > Strings in RPCs, such as the filename argument to a dir_lookup, are > > not checked if they are terminated by '\0'. This could lead to the > > server

Re: [bug #28446] No checks are made for unteminated strings in RPC messages

Hi, On Wed, Dec 30, 2009 at 07:42:21PM +, Carl Fredrik Hammar wrote: > Strings in RPCs, such as the filename argument to a dir_lookup, are > not checked if they are terminated by '\0'. This could lead to the > server segfaulting if it tries to read the string. > > Making MIG check that stri

[bug #28446] No checks are made for unteminated strings in RPC messages

URL: Summary: No checks are made for unteminated strings in RPC messages Project: The GNU Hurd Submitted by: hammy Submitted on: Wed 30 Dec 2009 08:42:20 PM CET Category: None