Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
Applied with the kd_putc_esc call fixed, thanks! Samuel

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
Yes, that was a mistake, it should call kd_putc_esc. James > On 29 Aug 2015, at 11:55, Samuel Thibault wrote: > > James Clarke, le Sat 29 Aug 2015 11:53:57 +0100, a écrit : >> I never gave that as an option? > > ? I understand even less. AIUI, before kd_start had esc support; with > your patc

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
James Clarke, le Sat 29 Aug 2015 11:53:57 +0100, a écrit : > I never gave that as an option? ? I understand even less. AIUI, before kd_start had esc support; with your patch it doesn't have any more. Probably Mach/Hurd never made use of it, but that's probably not a reason for removing the suppo

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
I never gave that as an option? James > On 29 Aug 2015, at 11:44, Samuel Thibault wrote: > > James Clarke, le Sat 29 Aug 2015 11:42:38 +0100, a écrit : >> Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd >> is actually using escape codes. >> >> I was trying to decid

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
James Clarke, le Sat 29 Aug 2015 11:42:38 +0100, a écrit : > Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd > is actually using escape codes. > > I was trying to decide whether putc should handle escape codes or whether it > should be left as outputting raw bytes to

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
Yes, it should be; since I didn't catch that I'd guess nothing in Mach/Hurd is actually using escape codes. I was trying to decide whether putc should handle escape codes or whether it should be left as outputting raw bytes to the display. As you can see I chose the latter, but do you think tha

Re: [RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread Samuel Thibault
James Clarke, le Sat 29 Aug 2015 11:15:29 +0100, a écrit : > @@ -1069,33 +1068,12 @@ kdstart(struct tty *tp) > break; > if ((tp->t_outq.c_cc <= 0) || (ch = getc(&tp->t_outq)) == -1) > break; > - c = ch; > /* >

[RFC] Fix printk not handling ANSI escape codes

2015-08-29 Thread James Clarke
* i386/i386at/kd.c (kdstart): Moved escape sequence handling to new kd_putc_esc function. (kd_putc_esc): New function with logic from kdstart. (kdcnputc): Call kd_putc_esc rather than kd_putc to allow for ANSI escape codes. * i386/i386at/kd.h (kd_putc_esc): New function. --- i386/i386at/kd.c | 63