Re: [PATCH v3] Fix race condition in ext2fs when remounting

2015-08-15 Thread James Clarke
Not sure how I missed that; will grep for any others. James > On 14 Aug 2015, at 13:16, Justus Winter <4win...@informatik.uni-hamburg.de> > wrote: > > Quoting James Clarke (2015-07-23 19:33:42) >> diff --git a/libdiskfs/disk-pager.c b/libdiskfs/disk-pager.c >> index 008aa2d..33b109c 100644 >> -

Re: [PATCH v3] Fix race condition in ext2fs when remounting

2015-08-14 Thread Justus Winter
Quoting James Clarke (2015-07-23 19:33:42) > diff --git a/libdiskfs/disk-pager.c b/libdiskfs/disk-pager.c > index 008aa2d..33b109c 100644 > --- a/libdiskfs/disk-pager.c > +++ b/libdiskfs/disk-pager.c > @@ -24,6 +24,7 @@ > __thread struct disk_image_user *diskfs_exception_diu; > > struct pager *

Re: [PATCH v3] Fix race condition in ext2fs when remounting

2015-07-27 Thread Thomas Schwinge
Hi! First, thanks for working on this issue! On Sat, 25 Jul 2015 14:06:24 +0200, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > What happened to the corresponding fatfs change though? Isofs is > read-only, and tmpfs' diskfs_reload_global_state is a nop too. So > modulo the missing

Re: [PATCH v3] Fix race condition in ext2fs when remounting

2015-07-25 Thread Justus Winter
Quoting Justus Winter (2015-07-25 03:54:59) > I'm merely wondering whether we shouldn't protect > diskfs_reload_global_state with a lock. I'm not sure if concurrent > remounts are a problem, but they could very well be. For the record, this is not a problem. There is the global diskfs_fsys_lock

Re: [PATCH v3] Fix race condition in ext2fs when remounting

2015-07-24 Thread Justus Winter
Hi James :) Quoting James Clarke (2015-07-23 19:33:42) > On some systems, ext2fs.static would regularly hang at startup, as a > race condition meant it would process paging requests while remounting. > To fix this, libpager has been altered to allow inhibiting and resuming > its worker threads, an

[PATCH v3] Fix race condition in ext2fs when remounting

2015-07-23 Thread James Clarke
On some systems, ext2fs.static would regularly hang at startup, as a race condition meant it would process paging requests while remounting. To fix this, libpager has been altered to allow inhibiting and resuming its worker threads, and ext2fs uses this to inhibit paging while remounting. * consol