Re: Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-03 Thread Samuel Thibault
Svante Signell, le lun. 03 déc. 2018 16:57:03 +0100, a ecrit: > I commented out the following three debian patches and updated my patch to > fcntl.c. > #hurd-i386/git-fcntl64.diff > #hurd-i386/git-lockf-0.diff > #hurd-i386/tg-WRLCK-upgrade.diff > hurd-i386/fcntl.diff Ok, then please say that, inst

Re: Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-03 Thread Svante Signell
On Mon, 2018-12-03 at 16:25 +0100, Samuel Thibault wrote: > Svante Signell, le lun. 03 déc. 2018 16:01:37 +0100, a ecrit: > > On Sat, 2018-12-01 at 19:30 +0100, Samuel Thibault wrote: > > > I forgot here: > > > > Is this really needed? > > Please quote a bit more than just that, otherwise we don'

Re: Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-03 Thread Samuel Thibault
Svante Signell, le lun. 03 déc. 2018 16:01:37 +0100, a ecrit: > On Sat, 2018-12-01 at 19:30 +0100, Samuel Thibault wrote: > > I forgot here: > > Is this really needed? Please quote a bit more than just that, otherwise we don't have any actual context. But actually, are you really talking about t

Re: Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-03 Thread Svante Signell
On Sat, 2018-12-01 at 19:30 +0100, Samuel Thibault wrote: > I forgot here: Is this really needed? From git-fcntl64.diff: Index: glibc-2.28/sysdeps/mach/hurd/fcntl.c === --- glibc-2.28.orig/sysdeps/mach/hurd/fcntl.c +++ glibc-2.28/sysd

Re: Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-01 Thread Samuel Thibault
I forgot here: Samuel Thibault, le sam. 01 déc. 2018 18:59:48 +0100, a ecrit: > case F_GETLK: > case F_SETLK: > case F_SETLKW: > { > struct flock *fl = va_arg (ap, struct flock *); > struct flock64 fl64 = { > .l_type = fl->l_type, > .l_whence = fl->l_w

Re: Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-01 Thread Samuel Thibault
Svante Signell, le sam. 01 déc. 2018 16:27:24 +0100, a ecrit: > On Thu, 2015-01-08 at 12:40 +0100, Svante Signell wrote: > > Attached is the patch adding support for file record locking in glibc, > > as implemented in Hurd by Neal Walfield and others. This patch should be > > applied after the corr

Comment on glibc2.28: Re: [PATCH glibc] Add file record locking support

2018-12-01 Thread Svante Signell
On Thu, 2015-01-08 at 12:40 +0100, Svante Signell wrote: > Hi, > > Attached is the patch adding support for file record locking in glibc, > as implemented in Hurd by Neal Walfield and others. This patch should be > applied after the corresponding hurd patch series in case glibc and hurd > are not

Re: [PATCH glibc] Add file record locking support

2015-01-20 Thread Svante Signell
On Tue, 2015-01-20 at 01:06 +0100, Samuel Thibault wrote: > Hello, > > Svante Signell, le Thu 08 Jan 2015 19:54:12 +0100, a écrit : > > You made me confused, so all changes were not made. I think the malloc > > version was better for symmetry reasons. Changed anyway. > > Which symmetry? You mean

Re: [PATCH glibc] Add file record locking support

2015-01-19 Thread Samuel Thibault
Hello, Svante Signell, le Thu 08 Jan 2015 19:54:12 +0100, a écrit : > You made me confused, so all changes were not made. I think the malloc > version was better for symmetry reasons. Changed anyway. Which symmetry? You mean fl->foo vs fl.foo? It is not worth spending a malloc call for this. > +

Re: [PATCH glibc] Add file record locking support

2015-01-08 Thread Svante Signell
On Thu, 2015-01-08 at 19:06 +0100, Guillem Jover wrote: > On Thu, 2015-01-08 at 18:03:31 +0100, Svante Signell wrote: > > On Thu, 2015-01-08 at 16:56 +0100, Guillem Jover wrote: > > > On Thu, 2015-01-08 at 12:40:12 +0100, Svante Signell wrote: > > Yes you are right, no checks are made. I removed t

Re: [PATCH glibc] Add file record locking support

2015-01-08 Thread Guillem Jover
On Thu, 2015-01-08 at 18:03:31 +0100, Svante Signell wrote: > On Thu, 2015-01-08 at 16:56 +0100, Guillem Jover wrote: > > On Thu, 2015-01-08 at 12:40:12 +0100, Svante Signell wrote: > > > Index: glibc-2.19/sysdeps/mach/hurd/fcntl.c > > > =

Re: [PATCH glibc] Add file record locking support

2015-01-08 Thread Svante Signell
On Thu, 2015-01-08 at 16:56 +0100, Guillem Jover wrote: > On Thu, 2015-01-08 at 12:40:12 +0100, Svante Signell wrote: > > Index: glibc-2.19/sysdeps/mach/hurd/fcntl.c > > === > > --- glibc-2.19.orig/sysdeps/mach/hurd/fcntl.c > > +++ gli

Re: [PATCH glibc] Add file record locking support

2015-01-08 Thread Guillem Jover
On Thu, 2015-01-08 at 12:40:12 +0100, Svante Signell wrote: > Index: glibc-2.19/sysdeps/mach/hurd/fcntl.c > === > --- glibc-2.19.orig/sysdeps/mach/hurd/fcntl.c > +++ glibc-2.19/sysdeps/mach/hurd/fcntl.c > @@ -128,56 +127,87 @@ __libc_f

[PATCH glibc] Add file record locking support

2015-01-08 Thread Svante Signell
Hi, Attached is the patch adding support for file record locking in glibc, as implemented in Hurd by Neal Walfield and others. This patch should be applied after the corresponding hurd patch series in case glibc and hurd are not built simultaneously. (Maybe the conversion functions as written by