Re: [PATCH 5/5] libtrivfs: fix an use-after-free error

2013-11-01 Thread Samuel Thibault
Thomas Schwinge, le Fri 25 Oct 2013 15:34:04 +0200, a écrit : > > I think it'd be clearer to unconditionally declare cntl before the if block > > and > > call pthread_mutex_unlock on &cntl->lock after the if block instead of > > inside > > the if and again inside the else. > > I agree; OK to pus

Re: [PATCH 5/5] libtrivfs: fix an use-after-free error

2013-10-25 Thread Thomas Schwinge
Hi! On Fri, 25 Oct 2013 15:15:22 +0200, Emilio Pozuelo Monfort wrote: > Minor nitpick: > > On 25/10/13 10:30, Justus Winter wrote: > > Found using the Clang Static Analyzer. > > > > * libtrivfs/protid-clean.c (trivfs_clean_protid): Fix use-after-free error. > > --- a/libtrivfs/protid-clean.c

Re: [PATCH 5/5] libtrivfs: fix an use-after-free error

2013-10-25 Thread Emilio Pozuelo Monfort
Minor nitpick: On 25/10/13 10:30, Justus Winter wrote: > Found using the Clang Static Analyzer. > > * libtrivfs/protid-clean.c (trivfs_clean_protid): Fix use-after-free error. > --- > libtrivfs/protid-clean.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libtri

[PATCH 5/5] libtrivfs: fix an use-after-free error

2013-10-25 Thread Justus Winter
Found using the Clang Static Analyzer. * libtrivfs/protid-clean.c (trivfs_clean_protid): Fix use-after-free error. --- libtrivfs/protid-clean.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libtrivfs/protid-clean.c b/libtrivfs/protid-clean.c index 856d7af..575dec3 100