See my previous review on this, you haven't addressed by comments.
Damien Zammit, le sam. 21 janv. 2023 08:05:06 +, a ecrit:
> ---
> i386/i386/cpu_number.c | 37 ++
> i386/i386/cpuboot.S| 164 +
> 2 files changed, 201 insertions(+)
> creat
On Wed, Jan 25, 2023 at 1:34 AM Jessica Clarke wrote:
> On 25 Jan 2023, at 06:27, Flávio Cruz wrote:
> >> On Tue, Jan 24, 2023 at 2:54 AM Samuel Thibault <
> samuel.thiba...@gnu.org> wrote:
> >> Flávio Cruz, le mar. 24 janv. 2023 01:15:15 -0500, a ecrit:
> >> > + int kernel_id;
> >> >
On 25 Jan 2023, at 06:27, Flávio Cruz wrote:
>> On Tue, Jan 24, 2023 at 2:54 AM Samuel Thibault
>> wrote:
>> Flávio Cruz, le mar. 24 janv. 2023 01:15:15 -0500, a ecrit:
>> > + int kernel_id;
>> > + unsigned long flags;
>> > +
>> > + cpu_intr_save(&flags);
>> >
On Tue, Jan 24, 2023 at 2:54 AM Samuel Thibault
wrote:
> Flávio Cruz, le mar. 24 janv. 2023 01:15:15 -0500, a ecrit:
> > + int kernel_id;
> > + unsigned long flags;
> > +
> > + cpu_intr_save(&flags);
> > +
> > + kernel_id = apic_get_cpu_kernel_id(ap
Hi:
I'm working together with Damien in this.
The SMP support is 32-bit yet, based in xAPIC instead x2APIC.
xAPIC is also compatible with 64-bit (although maybe can be necessary
enable manually in this mode) , but it's designed for 32-bit
El mar., 24 ene. 2023 8:54, Samuel Thibault
escribió:
>
Flávio Cruz, le mar. 24 janv. 2023 01:15:15 -0500, a ecrit:
> + int kernel_id;
> + unsigned long flags;
> +
> + cpu_intr_save(&flags);
> +
> + kernel_id = apic_get_cpu_kernel_id(apic_get_current_cpu());
> +
> + cpu_intr_restore(flags);
>
Hi Damien
On Sat, Jan 21, 2023 at 3:05 AM Damien Zammit wrote:
> ---
> i386/i386/cpu_number.c | 37 ++
> i386/i386/cpuboot.S| 164 +
> 2 files changed, 201 insertions(+)
> create mode 100644 i386/i386/cpu_number.c
> create mode 100644 i386/
---
i386/i386/cpu_number.c | 37 ++
i386/i386/cpuboot.S| 164 +
2 files changed, 201 insertions(+)
create mode 100644 i386/i386/cpu_number.c
create mode 100644 i386/i386/cpuboot.S
diff --git a/i386/i386/cpu_number.c b/i386/i386/cpu_number.c
n
