Re: [PATCH 3/3] Use reverse authenticating ioctl-handler protocal

2009-08-31 Thread olafBuddenhagen
Hi, On Wed, Aug 26, 2009 at 04:45:39PM +0200, Carl Fredrik Hammar wrote: > + err = EACCES; > + euid = geteuid (); > + for (i = 0; i < euids_len; i++) > +if (euids[i] == euid || euids[i] == 0) > + err = 0; This is not sufficient: privileges of the module are not escalated only if the

[PATCH 3/3] Use reverse authenticating ioctl-handler protocal

2009-08-26 Thread Carl Fredrik Hammar
* hurd/Makefile (interfaces): Add `ioctl_handler_reply'. * hurd/fd-ioctl-call.c: Check that handlers are provided by the same user. --- hurd/Makefile|3 +- hurd/fd-ioctl-call.c | 157 +- 2 files changed, 158 insertions(+), 2 deletions(-)