Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Cristian Rodríguez
a On Sat, Apr 29, 2023 at 9:12 AM Sergey Bugaev via Libc-alpha < libc-al...@sourceware.org> wrote: > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror () and similar > functions. > abort() and all the function wrappers called by

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Samuel Thibault
Cristian Rodríguez, le lun. 01 mai 2023 17:52:17 -0400, a ecrit: > On Sat, Apr 29, 2023 at 9:12 AM Sergey Bugaev via Libc-alpha <[1] > libc-al...@sourceware.org> wrote: > > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Samuel Thibault
Siddhesh Poyarekar, le lun. 01 mai 2023 12:15:04 -0400, a ecrit: > > > On 2023-04-29 11:06, Samuel Thibault via Libc-alpha wrote: > > It looks sensible to me indeed, any opinion from somebody else? > > > > > > > > > > Sergey Bugaev, le sam. 29 avril 2023 16:12:23 +0300, a ecrit: > > > GCC doc

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Siddhesh Poyarekar
On 2023-04-29 11:06, Samuel Thibault via Libc-alpha wrote: It looks sensible to me indeed, any opinion from somebody else? Sergey Bugaev, le sam. 29 avril 2023 16:12:23 +0300, a ecrit: GCC docs explicitly list perror () as a good candidate for using __attribute__ ((cold)). So apply __COLD

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-04-29 Thread Samuel Thibault
It looks sensible to me indeed, any opinion from somebody else? Sergey Bugaev, le sam. 29 avril 2023 16:12:23 +0300, a ecrit: > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror () and similar > functions. > > Signed-off-by: Se

[PATCH 3/3] Mark various cold functions as __COLD

2023-04-29 Thread Sergey Bugaev
GCC docs explicitly list perror () as a good candidate for using __attribute__ ((cold)). So apply __COLD to perror () and similar functions. Signed-off-by: Sergey Bugaev --- include/error.h | 4 ++-- libio/stdio.h | 2 +- misc/err.h | 12 ++-- misc/error.h| 4 ++-- 4 files