Re: [PATCH 2/2] proc: fix the receiver lookup in S_proc_exception_raise

2014-01-22 Thread Samuel Thibault
Justus Winter, le Mon 20 Jan 2014 10:26:35 +0100, a écrit : > * I like pflocal's solution best. The naming convention is concise > and it doesn't unnecessarily puts the translator functions in some > common header file like e.g. libdiskfs does. > > * libtrivfs and pfinet put the translator fu

Re: [PATCH 2/2] proc: fix the receiver lookup in S_proc_exception_raise

2014-01-20 Thread Samuel Thibault
Justus Winter, le Mon 20 Jan 2014 10:26:35 +0100, a écrit : > Because proc/proc_exc.defs is a private special version of > mach/exc.defs. Ah, right. Yes, when I asked I was thinking proc_exc.defs was a public interface. > I saw little value in making this mutable using mutator-macros. Yes, sure!

Re: [PATCH 2/2] proc: fix the receiver lookup in S_proc_exception_raise

2014-01-20 Thread Justus Winter
Quoting Samuel Thibault (2014-01-19 21:14:03) > Justus Winter, le Sat 18 Jan 2014 18:19:26 +0100, a écrit : > > * proc/mgt.c (S_proc_exception_raise): Update accordingly. > > * proc/mig-decls.h: New file. > > * proc/proc_exc.defs: Add translation functions. > > Why putting translation functions in

Re: [PATCH 2/2] proc: fix the receiver lookup in S_proc_exception_raise

2014-01-19 Thread Samuel Thibault
Justus Winter, le Sat 18 Jan 2014 18:19:26 +0100, a écrit : > * proc/mgt.c (S_proc_exception_raise): Update accordingly. > * proc/mig-decls.h: New file. > * proc/proc_exc.defs: Add translation functions. Why putting translation functions into proc_exc, rather than using mutation? > --- > proc/mg

[PATCH 2/2] proc: fix the receiver lookup in S_proc_exception_raise

2014-01-18 Thread Justus Winter
* proc/mgt.c (S_proc_exception_raise): Update accordingly. * proc/mig-decls.h: New file. * proc/proc_exc.defs: Add translation functions. --- proc/mgt.c | 7 ++- proc/mig-decls.h | 42 ++ proc/proc_exc.defs | 8 +++- 3 files changed, 51 i