Re: [PATCH 1/4] linux: fix bit tests

2014-01-06 Thread Justus Winter
Quoting Samuel Thibault (2014-01-06 02:41:03) > > * linux/src/drivers/net/tlan.c: Fix bit tests. > > * linux/src/drivers/scsi/AM53C974.c: Likewise. > > * linux/src/drivers/scsi/FlashPoint.c: Likewise. > > * linux/src/drivers/scsi/NCR5380.c: Likewise. > > * linux/src/drivers/scsi/t128.c: Likewise. >

Re: [PATCH 1/4] linux: fix bit tests

2014-01-05 Thread Samuel Thibault
Justus Winter, le Mon 06 Jan 2014 00:34:52 +0100, a écrit : > The pattern is !x&y. An expression of this form is almost always > meaningless, because it combines a boolean operator with a bit > operator. In particular, if the rightmost bit of y is 0, the result > will always be 0. > > Fixed using

[PATCH 1/4] linux: fix bit tests

2014-01-05 Thread Justus Winter
The pattern is !x&y. An expression of this form is almost always meaningless, because it combines a boolean operator with a bit operator. In particular, if the rightmost bit of y is 0, the result will always be 0. Fixed using coccinelle. // !x&y combines boolean negation with bitwise and // // Co