Re: [PATCH 1/2] qualify constants as const

2013-09-12 Thread Samuel Thibault
Marin Ramesa, le Fri 13 Sep 2013 00:16:57 +0200, a écrit : > On 11.09.2013 23:05:44, Samuel Thibault wrote: > > Marin Ramesa, le Tue 10 Sep 2013 10:38:04 +0200, a écrit : > > > #if DEBUG > > > -int cb_check_enable = 0; > > > +const int cb_check_enable = 0; > > > > I'd rather not. > > > > It

Re: [PATCH 1/2] qualify constants as const

2013-09-12 Thread Marin Ramesa
On 11.09.2013 23:05:44, Samuel Thibault wrote: > Marin Ramesa, le Tue 10 Sep 2013 10:38:04 +0200, a écrit : > > #ifDEBUG > > -int cb_check_enable = 0; > > +const int cb_check_enable = 0; > > I'd rather not. > > It is useful to be able to modify the value "live" from the debugger, > so as

Re: [PATCH 1/2] qualify constants as const

2013-09-11 Thread Samuel Thibault
Marin Ramesa, le Tue 10 Sep 2013 10:38:04 +0200, a écrit : > #if DEBUG > -int cb_check_enable = 0; > +const int cb_check_enable = 0; I'd rather not. It is useful to be able to modify the value "live" from the debugger, so as to enable the check only for some time while debugging. > #define

[PATCH 1/2] qualify constants as const

2013-09-10 Thread Marin Ramesa
* device/cirbuf.c (cb_check_enable) [DEBUG]: Qualify constant as const. --- device/cirbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device/cirbuf.c b/device/cirbuf.c index 4fe2d89..0ebff8e 100644 --- a/device/cirbuf.c +++ b/device/cirbuf.c @@ -42,7 +42,7 @@ /* if c_cl