Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

2013-11-20 Thread Samuel Thibault
Guillem Jover, le Wed 20 Nov 2013 23:50:59 +0100, a écrit : > On Wed, 2013-11-20 at 21:48:14 +0100, Samuel Thibault wrote: > > Guillem Jover, le Wed 20 Nov 2013 21:09:08 +0100, a écrit : > > > > #ifdef SOFTWARE_SSTEP > > > > + db_addr_t brpc; > > > > /* Account for instructio

Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

2013-11-20 Thread Guillem Jover
On Wed, 2013-11-20 at 21:48:14 +0100, Samuel Thibault wrote: > Guillem Jover, le Wed 20 Nov 2013 21:09:08 +0100, a écrit : > > > #ifdef SOFTWARE_SSTEP > > > + db_addr_t brpc; > > > /* Account for instructions in delay slots */ > > > brpc = next_instr_address(pc, 1, task); > > >

Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

2013-11-20 Thread Samuel Thibault
Guillem Jover, le Wed 20 Nov 2013 21:09:08 +0100, a écrit : > > #ifdef SOFTWARE_SSTEP > > + db_addr_t brpc; > > /* Account for instructions in delay slots */ > > brpc = next_instr_address(pc, 1, task); > > if ((brpc != pc) && (inst_branch(ins) || inst_call(ins)))

Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

2013-11-20 Thread Marin Ramesa
On 20.11.2013 21:09:08, Guillem Jover wrote: > This adds intermixing of statements and declarations. Is that not desireable. In this way GCC doesn't complain about unused variable.

Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

2013-11-20 Thread Guillem Jover
Hi! On Wed, 2013-11-20 at 13:53:51 +0100, Marin Ramesa wrote: > diff --git a/ddb/db_run.c b/ddb/db_run.c > index 22cd358..60b34bf 100644 > --- a/ddb/db_run.c > +++ b/ddb/db_run.c > @@ -171,7 +171,7 @@ db_restart_at_pc(watchpt, task) > boolean_t watchpt; > task_ttask; > { > - d

[PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

2013-11-20 Thread Marin Ramesa
* ddb/db_run.c (brpc): Move declaration into SOFTWARE_SSTEP code. --- ddb/db_run.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ddb/db_run.c b/ddb/db_run.c index 22cd358..60b34bf 100644 --- a/ddb/db_run.c +++ b/ddb/db_run.c @@ -171,7 +171,7 @@ db_restart_at_pc(watchpt, ta