Re: [PATCH 09/15] Hurd signals: implement global signal dispositions

2011-07-22 Thread Jérémie Koenig
On Sun, Jul 3, 2011 at 2:16 AM, Samuel Thibault wrote: >> --- a/sysdeps/mach/hurd/spawni.c >> +++ b/sysdeps/mach/hurd/spawni.c (...) >> +  ints[INIT_SIGPENDING] = _hurd_sigstate_pending (ss); /* XXX really? */ > > Mmm. According to POSIX, fork() is supposed to clear pending signals, > but GNU/Hurd

Re: [PATCH 09/15] Hurd signals: implement global signal dispositions

2011-07-19 Thread Jeremie Koenig
On Wed, Jul 06, 2011 at 01:09:27AM +0200, Samuel Thibault wrote: > Jeremie Koenig, le Tue 05 Jul 2011 05:15:28 +0200, a écrit : > > I was worried about a case where the user would install a minuscule > > stack, sufficient for their own handler, but not for a preemptor's one. > > I believe the user

Re: [PATCH 09/15] Hurd signals: implement global signal dispositions

2011-07-05 Thread Samuel Thibault
Jeremie Koenig, le Tue 05 Jul 2011 05:15:28 +0200, a écrit : > > These should probably be made extern inline. > > I agree as far as internal libc usage is concerned. Yes. I wasn't meaning extern inline to outside libc. "extern inline" precisely means that we also provide the symbol, for those wh

Re: [PATCH 09/15] Hurd signals: implement global signal dispositions

2011-07-04 Thread Jeremie Koenig
On Sun, Jul 03, 2011 at 02:16:34AM +0200, Samuel Thibault wrote: > Jeremie Koenig, le Wed 29 Jun 2011 18:30:21 +0200, a écrit : > > +sigstate_is_global_rcv (const struct hurd_sigstate *ss) > > +_hurd_sigstate_lock (struct hurd_sigstate *ss) > > +_hurd_sigstate_unlock (struct hurd_sigstate *ss) > >

Re: [PATCH 09/15] Hurd signals: implement global signal dispositions

2011-07-02 Thread Samuel Thibault
Jeremie Koenig, le Wed 29 Jun 2011 18:30:21 +0200, a écrit : > Currently each thread has a full "sigstate" structure which keeps track > of the signal dispositions, blocking mask and pending signals for this > thread. Process-wide signals are delivered to the main thread. > > However, the semantic

[PATCH 09/15] Hurd signals: implement global signal dispositions

2011-06-29 Thread Jeremie Koenig
Currently each thread has a full "sigstate" structure which keeps track of the signal dispositions, blocking mask and pending signals for this thread. Process-wide signals are delivered to the main thread. However, the semantics for POSIX threads is that all of them share the same signal dispositi