Re: [PATCH 07/13] trans: return nodes locked when creating fake nodes in fakeroot

2013-12-10 Thread Samuel Thibault
Justus Winter, le Tue 10 Dec 2013 10:20:45 +0100, a écrit : > Quoting Samuel Thibault (2013-12-10 01:08:21) > > Justus Winter, le Mon 09 Dec 2013 15:16:35 +0100, a écrit : > > > + { > > > + pthread_mutex_lock (&(*np)->lock); > > > + netfs_nref (*np); /* Return a reference to the

Re: [PATCH 07/13] trans: return nodes locked when creating fake nodes in fakeroot

2013-12-10 Thread Justus Winter
Quoting Samuel Thibault (2013-12-10 01:08:21) > Justus Winter, le Mon 09 Dec 2013 15:16:35 +0100, a écrit : > > + { > > + pthread_mutex_lock (&(*np)->lock); > > + netfs_nref (*np); /* Return a reference to the caller. */ > > + } > >pthread_mutex_unlock (&idport_ihas

Re: [PATCH 07/13] trans: return nodes locked when creating fake nodes in fakeroot

2013-12-09 Thread Samuel Thibault
Justus Winter, le Mon 09 Dec 2013 15:16:35 +0100, a écrit : > + { > + pthread_mutex_lock (&(*np)->lock); > + netfs_nref (*np); /* Return a reference to the caller. */ > + } >pthread_mutex_unlock (&idport_ihash_lock); Did you check the lock ordering between these tw

[PATCH 07/13] trans: return nodes locked when creating fake nodes in fakeroot

2013-12-09 Thread Justus Winter
* trans/fakeroot.c (new_node): Acquire the nodes lock before releasing the idport_ihash_lock. Return nodes locked. (netfs_S_dir_lookup): Drop lock. (netfs_attempt_mkfile): Likewise. (main): Likewise. --- trans/fakeroot.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-)