Re: [PATCH] proc: Fix pointer truncation in get_string_array

2023-06-21 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 21 juin 2023 13:56:38 +0300, a ecrit: > Due to little-endianness of x86, this resulted in a 64-bit pointers that > pointed to the lower 4 GB of the address space being treated as a 32-bit > pointer followed by NULL, which manifested as only the first program

[PATCH] proc: Fix pointer truncation in get_string_array

2023-06-21 Thread Sergey Bugaev
Due to little-endianness of x86, this resulted in a 64-bit pointers that pointed to the lower 4 GB of the address space being treated as a 32-bit pointer followed by NULL, which manifested as only the first program arg (the argv[0]) being visible in ps output. When a pointer pointed outside of the

Re: [PATCH] proc: cleanup

2001-04-15 Thread Roland McGrath
Thanks, I've applied these changes. In future, please refrain from gratuitous editting of comments. Fixing typos or errors is a good thing, and changing comments to be more informative is fine. But trivial changes to punctuation and phraseology don't really add anything and they clutter up your

[PATCH] proc: cleanup

2001-04-13 Thread Neal H Walfield
This includes, among others, the proposed changes that I sent on March 26. 2000-04-03 Neal H Walfield <[EMAIL PROTECTED]> * proc.h (struct ids): Drop gids and ngids, we never use them. Turn uids into a zero length array. * mgt.c (make_ids): Conform to new semantics.

[PATCH] proc

2001-03-26 Thread Neal H Walfield
General return value checks, documentation fixes etc. diff -urN hurd-20010307-snapshot/proc/ChangeLog hurd-20010313/proc/ChangeLog --- hurd-20010307-snapshot/proc/ChangeLog Fri Mar 17 11:36:33 2000 +++ hurd-20010313/proc/ChangeLogMon Mar 26 20:57:24 2001 @@ -1,3 +1,48 @@ +2001-03-25