Re: [PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-31 Thread Justus Winter
Quoting Samuel Thibault (2014-08-29 23:13:08) > Justus Winter, le Fri 29 Aug 2014 11:33:44 +0200, a écrit : > > Previously, peropen objects were created with a reference count of > > zero. Therefore, if diskfs_create_protid fails, passing such an > > object to diskfs_release_peropen would lead to

Re: [PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-29 Thread Samuel Thibault
Justus Winter, le Fri 29 Aug 2014 11:33:44 +0200, a écrit : > Previously, peropen objects were created with a reference count of > zero. Therefore, if diskfs_create_protid fails, passing such an > object to diskfs_release_peropen would lead to a reference count > underflow. I see, it is indeed mo

Re: [PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-29 Thread Neal H. Walfield
At Fri, 29 Aug 2014 12:50:28 +0200, Justus Winter wrote: > > Quoting Neal H. Walfield (2014-08-29 11:55:07) > > At Fri, 29 Aug 2014 11:33:44 +0200, > > Justus Winter wrote: > > > Previously, peropen objects were created with a reference count of > > > zero. Therefore, if diskfs_create_protid fail

Re: [PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-29 Thread Justus Winter
Quoting Neal H. Walfield (2014-08-29 11:55:07) > At Fri, 29 Aug 2014 11:33:44 +0200, > Justus Winter wrote: > > Previously, peropen objects were created with a reference count of > > zero. Therefore, if diskfs_create_protid fails, passing such an > > object to diskfs_release_peropen would lead to

Re: [PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-29 Thread Neal H. Walfield
At Fri, 29 Aug 2014 11:33:44 +0200, Justus Winter wrote: > Previously, peropen objects were created with a reference count of > zero. Therefore, if diskfs_create_protid fails, passing such an > object to diskfs_release_peropen would lead to a reference count > underflow. > > * libdiskfs/peropen-m

[PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-29 Thread Justus Winter
Previously, peropen objects were created with a reference count of zero. Therefore, if diskfs_create_protid fails, passing such an object to diskfs_release_peropen would lead to a reference count underflow. * libdiskfs/peropen-make.c (diskfs_peropen_make): Initialize reference count to one. * lib