Re: [PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR

2016-04-11 Thread Markus Trippelsdorf
On 2016.04.02 at 12:57 +0200, Samuel Thibault wrote: > Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and > getauxval would thus crash. Your commit 0cdc5e930a breaks the build for me: In file included from ../sysdeps/x86_64/ldsodefs.h:54:0, from ../sysdeps/gnu/ldsode

Re: [PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR

2016-04-11 Thread Samuel Thibault
Hello, Markus Trippelsdorf, on Mon 11 Apr 2016 09:55:12 +0200, wrote: > On 2016.04.02 at 12:57 +0200, Samuel Thibault wrote: > > Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and > > getauxval would thus crash. > > Your commit 0cdc5e930a breaks the build for me: Ah, sorry, part of

Re: [PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR

2016-04-04 Thread Roland McGrath
> On 02 Apr 2016 12:57, Samuel Thibault wrote: > > Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and > > getauxval would thus crash. > > assuming this is for GNU/hurd Yes. > should this just be under HAVE_AUX_VECTOR ? seems like we shouldn't > even bother defining/exporting dl_aux

Re: [PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR

2016-04-02 Thread Mike Frysinger
On 02 Apr 2016 12:57, Samuel Thibault wrote: > Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and > getauxval would thus crash. assuming this is for GNU/hurd > --- a/misc/getauxval.c > +++ b/misc/getauxval.c > @@ -30,9 +30,10 @@ __getauxval (unsigned long int type) >else if (type

[PATCH] getauxval: fix crash on systems without HAVE_AUX_VECTOR

2016-04-02 Thread Samuel Thibault
Systems without HAVE_AUX_VECTOR have GLRO(dl_auxv) == NULL, and getauxval would thus crash. * misc/getauxval.c (__getauxval): Check for GLRO(dl_auxv) != NULL before looping through the list. diff --git a/misc/getauxval.c b/misc/getauxval.c index e48f40f..7ba0598 100644 --- a/misc/getauxval.c +++