Re: [PATCH] ftpfs: fix host lookup error handling

2019-08-28 Thread Krzysztof Piecuch
Hello, thanks for the code review. I'll submit fixes in a while. Kind regards, Krzysztof Piecuch Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Monday, August 26, 2019 7:36 PM, Samuel Thibault wrote: > Hello, > > Krzysztof Piecuch, le lun. 26 août 2019 17:54:55 +,

Re: [PATCH] ftpfs: fix host lookup error handling

2019-08-26 Thread Samuel Thibault
Hello, Krzysztof Piecuch, le lun. 26 août 2019 17:54:55 +, a ecrit: > - if (gethostbyname_r (host, &_he, hostent_data, sizeof hostent_data, > -&he, h_err) == 0) > + do { > +bufsize *= 2; > +hostent_data = realloc(hostent_data, bufsize); > +if (!hostent_data) >

Re: [PATCH] ftpfs: fix host lookup error handling

2019-08-26 Thread Krzysztof Piecuch
n, 26 Aug 2019 13:43:18 -0400 Subject: [PATCH] ftpfs: fix host lookup error handling --- ftpfs/host.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/ftpfs/host.c b/ftpfs/host.c index cd6fd4c0..ba1689b1 100644 --- a/ftpfs/host.c +++ b/ftpfs/host.c @@ -101,7

[PATCH] ftpfs: fix host lookup error handling

2019-08-26 Thread Krzysztof Piecuch
19 13:43:18 -0400 Subject: [PATCH] ftpfs: fix host lookup error handling --- ftpfs/host.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/ftpfs/host.c b/ftpfs/host.c index cd6fd4c0..dab77046 100644 --- a/ftpfs/host.c +++ b/ftpfs/host.c @@ -101,7 +1

Re: [PATCH] ftpfs

2002-10-23 Thread Thomas Bushnell, BSG
Moritz Schulte <[EMAIL PROTECTED]> writes: > Just curious; was there something wrong with that patch? Nothing that pops out at first, but perhaps nobody has had a chance to look at it in detail. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.

Re: [PATCH] ftpfs

2002-10-22 Thread Moritz Schulte
Just curious; was there something wrong with that patch? moritz -- [EMAIL PROTECTED] - http://duesseldorf.ccc.de/~moritz/ GPG fingerprint = 3A14 3923 15BE FD57 FC06 B501 0841 2D7B 6F98 4199 ___ Bug-hurd mailing list [EMAIL PROTECTED]

Re: [PATCH] ftpfs/libftpconn

2002-04-19 Thread Marcus Brinkmann
On Sat, Apr 13, 2002 at 02:25:07AM +0200, Moritz Schulte wrote: > I investigated the problem, which caused ftpfs to fail with some ftp > servers (e.g. ftp.debian.org). The problem is that libftpconn > sometimes tries to 'list' _directories_ and not _entries in a > directory_. Hi, thanks again f

Re: [PATCH] ftpfs/libftpconn

2002-04-15 Thread Marcus Brinkmann
On Sat, Apr 13, 2002 at 02:25:07AM +0200, Moritz Schulte wrote: > I investigated the problem, which caused ftpfs to fail with some ftp > servers (e.g. ftp.debian.org). The problem is that libftpconn > sometimes tries to 'list' _directories_ and not _entries in a > directory_. Cool, thanks for tr

Re: [PATCH] ftpfs/libftpconn

2002-04-14 Thread Moritz Schulte
[EMAIL PROTECTED] (Niels Möller) writes: >> I haven't found a way in the FTP protocol, which helps us here. > > In theory, the command "mlst" should help. Aah, this seems to be a very good idea in the FTP protocol, especially because it's easy to parse. If that is well supported by FTP servers,

Re: [PATCH] ftpfs/libftpconn

2002-04-14 Thread Niels Möller
Moritz Schulte <[EMAIL PROTECTED]> writes: > I haven't found a way in the FTP protocol, which helps us here. In theory, the command "mlst" should help. But it's also underspecified and not always implemented. For example, ftp.roxen.com implements it like this: $ ftp ftp.roxen.com Connected

[PATCH] ftpfs/libftpconn

2002-04-12 Thread Moritz Schulte
Hello, I investigated the problem, which caused ftpfs to fail with some ftp servers (e.g. ftp.debian.org). The problem is that libftpconn sometimes tries to 'list' _directories_ and not _entries in a directory_. But obviously that isn't supported by all ftp servers, see: lftp ftp.debian.org:~>