Re: [PATCH] Trivial fix on an argument in ftpfs

2006-07-11 Thread Thomas Schwinge
Hello! On Sat, Jul 30, 2005 at 04:21:42AM +0200, Samuel Thibault wrote: > [...] > 2005-07-30 Samuel Thibault <[EMAIL PROTECTED]> > > * ihash.c (add_one): Correct cast. > > Index: libihash/ihash.c > === > RCS file: /cvsroot

Re: [EMAIL PROTECTED]: Re: [PATCH] Trivial fix on an argument in ftpfs]

2005-08-25 Thread Alfred M\. Szmidt
Commited to ams-branch. ftpfs/ChangeLog 2005-07-30 Samuel Thibault <[EMAIL PROTECTED]> * node.c (ftpfs_create_node): Check the result from hurd_ihash_add (). Add E to the hash table instead of NEW. libihash/ChangeLog 2005-07-30 Samuel Thibault <[EMAIL PROTECTED]> *

[EMAIL PROTECTED]: Re: [PATCH] Trivial fix on an argument in ftpfs]

2005-08-04 Thread Alfred M\. Szmidt
Ping... --- Start of forwarded message --- From: "Alfred M\. Szmidt" <[EMAIL PROTECTED]> To: bug-hurd@gnu.org Date: Sat, 30 Jul 2005 14:33:07 +0200 Subject: Re: [PATCH] Trivial fix on an argument in ftpfs Looks ok, I haven't tested it, but Samuel told me that he had.

Re: [PATCH] Trivial fix on an argument in ftpfs

2005-07-30 Thread Alfred M\. Szmidt
This patch looks fine to me. Can I apply it? Samuel's patch fixes the problem at the proper place, this one doesn't. ___ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: [PATCH] Trivial fix on an argument in ftpfs

2005-07-30 Thread Marco Gerards
Anders Juel Jensen <[EMAIL PROTECTED]> writes: Hi, > Just a small fix in ftpfs, it was probably just a typo in the first > place. This patch looks fine to me. Can I apply it? Thanks, Marco ___ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.g

Re: [PATCH] Trivial fix on an argument in ftpfs

2005-07-30 Thread Alfred M\. Szmidt
Looks ok, I haven't tested it, but Samuel told me that he had. Roland, OK to commit? ftpfs/ChangeLog 2005-07-30 Samuel Thibault <[EMAIL PROTECTED]> * node.c (ftpfs_create_node): Check the result from hurd_ihash_add (). Add E to the hash table instead of NEW. libihash/ChangeLo

Re: [PATCH] Trivial fix on an argument in ftpfs

2005-07-29 Thread Samuel Thibault
Hi, Well, I'm sorry, but I don't think that this is the good correction :) inode_locp *is* a hurd_ihash_locp_t, and hurd_ihash_remove() wants that. There is just a mis-casting in add_one(): 2005-07-30 Samuel Thibault <[EMAIL PROTECTED]> * ihash.c (add_one): Correct cast. Index: libiha

Re: [PATCH] Trivial fix on an argument in ftpfs

2005-07-29 Thread Anders Juel Jensen
hi again, Alfred requested to see "proof" that there really is a bug here. So this is just for you :-) (btw, check ihash.h if you want to know why i am so sure) Attaching to program `/home/macavity/hurd/ftpfs', pid 26673 Reading symbols from /home/macavity/lib/libhurdbugaddr.so.0.3...done. Loade

Re: [PATCH] Trivial fix on an argument in ftpfs

2005-07-29 Thread Michael Banck
On Fri, Jul 29, 2005 at 05:39:30PM +, Anders Juel Jensen wrote: > Just a small fix in ftpfs, it was probably just a typo in the first > place. Thanks, I put this into the Debian package. >/* Remove this entry from the set of known inodes. */ >spin_lock (&nn->fs->inode_mappings_lock

[PATCH] Trivial fix on an argument in ftpfs

2005-07-29 Thread Anders Juel Jensen
Hi. Just a small fix in ftpfs, it was probably just a typo in the first place. ~Anders Juel Jensen (aka macavity on IRC) PS.: Thanks to hde, bing, youpi, antrik and marco_g for putting up with all my newbe questions. It motivates me a lot when people bother to invest their time in me. 2005-07-