Re: [PATCH] Support invoking the debugger over the serial console

2014-08-22 Thread Neal H. Walfield
At Thu, 21 Aug 2014 13:16:01 +0200, Samuel Thibault wrote: > > Hello, > > Thanks for sharing, I've had this kind of patch in my tree for a long > with another, easier to parse, keypress, but this implementation seems > nice as it keeps it ctrl-alt-d. > > Justus Winter, le Thu 21 Aug 2014 12:14:5

Re: [PATCH] Support invoking the debugger over the serial console

2014-08-21 Thread Samuel Thibault
Applied, thanks! Samuel

[PATCH] Support invoking the debugger over the serial console

2014-08-21 Thread Justus Winter
* i386/i386at/com.c (comintr): Invoke the debugger if ctrl-alt-d is pressed. * i386/i386at/com.h (kdb_kintr): Add declaration. --- i386/i386at/com.c | 27 ++- i386/i386at/com.h | 4 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/i386/i386at/com.c b/i38

Re: [PATCH] Support invoking the debugger over the serial console

2014-08-21 Thread Samuel Thibault
Justus Winter, le Thu 21 Aug 2014 14:54:13 +0200, a écrit : > > I like using 'C'-'@' instead of the magic-looking 4 :) > > Surely you meant 'D'-'@', Oops, sure :) Samuel

Re: [PATCH] Support invoking the debugger over the serial console

2014-08-21 Thread Justus Winter
Hi :) Quoting Samuel Thibault (2014-08-21 13:16:01) > Mmm, but this means that an escape alone will be lost, which is a real > problem for e.g. using vim :) Right, that came to my mind after I send the patch (as always...). > Can't escape rather be an static array indexed by unit number? I beli

Re: [PATCH] Support invoking the debugger over the serial console

2014-08-21 Thread Samuel Thibault
Hello, Thanks for sharing, I've had this kind of patch in my tree for a long with another, easier to parse, keypress, but this implementation seems nice as it keeps it ctrl-alt-d. Justus Winter, le Thu 21 Aug 2014 12:14:50 +0200, a écrit : > if (tp->t_state&TS_ISOPEN) { > +

[PATCH] Support invoking the debugger over the serial console

2014-08-21 Thread Justus Winter
* i386/i386at/com.c (comintr): Invoke the debugger if ctrl-alt-d is pressed. * i386/i386at/com.h (kdb_kintr): Add declaration. --- i386/i386at/com.c | 23 ++- i386/i386at/com.h | 4 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/i386/i386at/com.c b/i386/i3