Re: [PATCH] Check for rendezvous port death in auth server

2012-07-02 Thread hammy . lite
On Sun, Jul 1, 2012 at 10:36 PM, wrote: > This patch no longer applies cleanly. I'll have another look at it tomorrow > but I fear I have lost my grip on the details so I'm not sure I can fix it up > with any confidence. It was straight-forward after all so I committed! Regards, Fredrik

Re: [PATCH] Check for rendezvous port death in auth server

2012-07-01 Thread hammy . lite
On Sun, Jul 1, 2012 at 6:25 AM, Samuel Thibault wrote: > Carl Fredrik Hammar, le Tue 01 Jun 2010 19:53:08 +0200, a écrit : >> * auth/auth.c (S_auth_user_authenticate,S_auth_server_authenticate): >> Return EINVAL if rendezvous port dies during transaction. >> >> Shall I commit? > > It looks good to

Re: [PATCH] Check for rendezvous port death in auth server

2012-06-30 Thread Samuel Thibault
Carl Fredrik Hammar, le Tue 01 Jun 2010 19:53:08 +0200, a écrit : > * auth/auth.c (S_auth_user_authenticate,S_auth_server_authenticate): > Return EINVAL if rendezvous port dies during transaction. > > Shall I commit? It looks good to me. Samuel

Re: [PATCH] Check for rendezvous port death in auth server

2010-06-03 Thread Carl Fredrik Hammar
Hi, On Thu, Jun 03, 2010 at 06:55:12AM +0200, olafbuddenha...@gmx.net wrote: > On Wed, Jun 02, 2010 at 06:35:02PM +0200, Carl Fredrik Hammar wrote: > > On Wed, Jun 02, 2010 at 12:17:12AM +0200, olafbuddenha...@gmx.net > > wrote: > > > > I'm a bit ambivalent about this... On one hand, returning th

Re: [PATCH] Check for rendezvous port death in auth server

2010-06-02 Thread olafBuddenhagen
Hi, On Wed, Jun 02, 2010 at 06:35:02PM +0200, Carl Fredrik Hammar wrote: > On Wed, Jun 02, 2010 at 12:17:12AM +0200, olafbuddenha...@gmx.net > wrote: > > I'm a bit ambivalent about this... On one hand, returning the right > > error code right away is probably less confusing; but on the other > >

Re: [PATCH] Check for rendezvous port death in auth server

2010-06-02 Thread Carl Fredrik Hammar
Hi, On Wed, Jun 02, 2010 at 12:17:12AM +0200, olafbuddenha...@gmx.net wrote: > > I'm a bit ambivalent about this... On one hand, returning the right > error code right away is probably less confusing; but on the other hand, > it adds extra code paths (with all the associated disadvantages) for >

Re: [PATCH] Check for rendezvous port death in auth server

2010-06-01 Thread olafBuddenhagen
Hi, On Tue, Jun 01, 2010 at 07:53:08PM +0200, Carl Fredrik Hammar wrote: > This is a patch for the auth server to make it also return EINVAL when > the rendezvous port has died during a transaction and not only if it > is dead on arrival, as discussed earlier on IRC. > > This is probably not an

[PATCH] Check for rendezvous port death in auth server

2010-06-01 Thread Carl Fredrik Hammar
* auth/auth.c (S_auth_user_authenticate,S_auth_server_authenticate): Return EINVAL if rendezvous port dies during transaction. --- Hello, This is a patch for the auth server to make it also return EINVAL when the rendezvous port has died during a transaction and not only if it is dead on arrival,