Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2019-10-27 Thread Joan Lledó via Bug reports for the GNU Hurd
Hello Hurd, I made some changes to this patch: 1- I added a call to pci_system_cleanup(); in the shutdown RPC, so libpciaccess is shutdown correctly. 2- As now we're using libpciaccess functions to read/write from netfs_attempt_read/write, and these two libpciaccess functions have diffe

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-12-05 Thread Thomas Schwinge
Hi! On Sun, 11 Nov 2018 13:14:59 +1100, Damien Zammit wrote: > On 11/11/18 13:05, Samuel Thibault wrote: > > Do you know how your copyright assignment is going, so I can commit it? > > Haven't heard anything since I sent through my request. This has yesterday been reported as completed in email

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Damien Zammit
On 11/11/18 13:05, Samuel Thibault wrote: > Do you know how your copyright assignment is going, so I can commit it? Haven't heard anything since I sent through my request. Damien

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Samuel Thibault
Hello, Thanks for the revised patch :) Do you know how your copyright assignment is going, so I can commit it? Samuel

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Damien Zammit
On 10/11/18 20:42, Samuel Thibault wrote: > Damien Zammit, le sam. 10 nov. 2018 18:58:35 +1100, a ecrit: >> +CPPFLAGS += -imacros $(srcdir)/config.h > > Why is this needed? I have now removed config.h and this line. > So it seems that libpciaccess doesn't provide an interface for this. > Please

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Samuel Thibault
Hello, Thanks for this :) Damien Zammit, le sam. 10 nov. 2018 18:58:35 +1100, a ecrit: > @@ -35,6 +35,8 @@ include ../Makeconf > > CFLAGS += -I$(PORTDIR)/include > > +CPPFLAGS += -imacros $(srcdir)/config.h Why is this needed? (that's the reason why you have to add a config.h file, but its

[PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Damien Zammit
Hi all, This patch (see attached) removes all embedded pciaccess code from the arbiter, and adds config.h which is currently missing from master. NB: I have another patch for libpciaccess to add the hurd method and add Joan's tweaks to the raw x86 access method, but is not strictly essential to u