Roland McGrath, le Thu 28 Aug 2014 13:04:14 -0700, a écrit :
> > This is what I had put, is some information still missing?
>
> Oh, was that in the message? I must have missed it because I didn't see a
> ChangeLog header.
Ah, probably, indeed.
> (though it's ok to omit " (__fork)" in a libc fil
> This is what I had put, is some information still missing?
Oh, was that in the message? I must have missed it because I didn't see a
ChangeLog header.
> * sysdeps/mach/hurd/fork.c (__fork): Lock SS->lock around __proc_dostop()
> call.
Don't use () as if it were part of a function name. Othe
Roland McGrath, le Thu 28 Aug 2014 11:21:08 -0700, a écrit :
> Fix comment formatting, put space before paren,
Right, I really need to teach my editor to do the comments properly
automatically...
> write a ChangeLog entry.
This is what I had put, is some information still missing?
* sysdeps/mac
Fix comment formatting, put space before paren, write a ChangeLog entry.
(Building the petsc package consistently reproduces the issue several
times during the build, while I could build the package twice without
any issue with the patch applied).
Samuel
If e.g. a signal is being received while we are running fork(), the signal
thread may be having our SS lock when we make the space copy, and thus in the
child we can not take the SS lock any more.
* sysdeps/mach/hurd/fork.c (__fork): Lock SS->lock around __proc_dostop() call.
Signed-off-by: Samue