> > libc code can use C99 freely these days, so use an inline
> > initializing declaration rather than pre-declaring a new variable.
>
> Hm ok; is it bad if I leave them as it is, for now?
It's not terrible but there is no reason to let new code in that is not in
optimal style, and it's trivial t
Alle sabato 28 aprile 2012, Roland McGrath ha scritto:
> You can just use string_t and no need for the XXX comment.
Fixed. (I initially made my changes as less intrusive as possible.)
> libc code can use C99 freely these days, so use an inline
> initializing declaration rather than pre-declaring
You can just use string_t and no need for the XXX comment.
libc code can use C99 freely these days, so use an inline initializing
declaration rather than pre-declaring a new variable.
I don't think there's any need to iniitalize the result buffer. We trust
the RPC stubs to return a properly-te
Hi,
attached there is a patch to fix few issues in Hurd's getlogin_r():
avoid a static buffer, and check for buffer shorter than necessary.
Thanks,
--
Pino Toscano
hurd: compliance fixes for getlogin_r
* do not make `login' static, as it would make getlogin_r no more reentrant
* fail with ERAN
