Marin Ramesa, le Sun 07 Jul 2013 09:41:24 +0200, a écrit :
> On 05.07.2013 14:55:32, Marin Ramesa wrote:
> > Putting 'extern int _setjmp(jmp_buf_t*)' to i386/i386/setjmp.h
> > removes three implicit declaration warnings.
>
> Actually four, if db_trap.c includes .
> * ddb/db_trap.c: Include .
> *
On 05.07.2013 14:55:32, Marin Ramesa wrote:
> Putting 'extern int _setjmp(jmp_buf_t*)' to i386/i386/setjmp.h
> removes three implicit declaration warnings.
Actually four, if db_trap.c includes .
* ddb/db_trap.c: Include .
* i386/i386/setjmp.h (_setjmp): Add prototype.
From 5d45a0928eb803e776
On 05.07.2013 09:45:39, Samuel Thibault wrote:
> Err, no, the point of putting it in a .h file is to put it into a
> single place, so you're sure everybody agree on the definition since
> it's written only once. The .h file where it's supposed to go has to
> be related with the function itself, e
Marin Ramesa, le Fri 05 Jul 2013 08:23:22 +0200, a écrit :
> On 04.07.2013 23:11:19, Samuel Thibault wrote:
> > Please rather put it into a .h file.
>
> * ddb/db_command.h (_setjmp): Add prototype.
> * kern/xpr.h (_setjmp): Add prototype.
Err, no, the point of putting it in a .h file is to put i
On 04.07.2013 23:11:19, Samuel Thibault wrote:
> Please rather put it into a .h file.
Here's the patch:
* ddb/db_command.h (_setjmp): Add prototype.
* kern/xpr.h (_setjmp): Add prototype.
=46rom b5f866f80206845700c242f5005495ca20e57206 Mon Sep 17 00:00:00 2001
From: Marin Ramesa
Date: Fri, 5 Ju
Marin Ramesa, le Thu 04 Jul 2013 23:35:14 +0200, a écrit :
> I have no idea how that crept into the patch. I noticed these strange
> changes after I started using diff -Nurp.
It's some white spaces at the end of the lines.
Samuel
> > +++ ../gnumach1/ddb/db_examine.h2013-07-03
> > 10:27:57.205341927 +0200
> > @@ -26,8 +26,8 @@
> > #include
> >
> > extern void db_examine_cmd (
> > - db_expr_t addr,
> > - int have_addr,
> > + db_expr_t addr,
> > + int have_addr,
>
> This looks like spurious change.
>
> Samuel
Marin Ramesa, le Wed 03 Jul 2013 11:35:31 +0200, a écrit :
> When building with --enable-kdb.
Commited the rest, thanks!
Samuel
Marin Ramesa, le Wed 03 Jul 2013 11:35:31 +0200, a écrit :
> +++ ../gnumach1/ddb/db_command.c 2013-07-03 11:10:49.201495677 +0200
> +extern int _setjmp();
> +++ ../gnumach1/ddb/db_cond.c 2013-07-03 11:11:02.679288690 +0200
> +extern int _setjmp();
Please rather put it into a .h file.
> +++ .
On Wed, Jul 03, 2013 at 03:58:44PM +0200, Marin Ramesa wrote:
> No problem. I have read the git documentation and will use git format-
> patch in the future. I was not aware that I am creating extra work for
> people. And please say if there is something specifically wrong with
Not that much ext
On 03.07.2013 12:28:31, Richard Braun wrote:
> On Wed, Jul 03, 2013 at 11:35:31AM +0200, Marin Ramesa wrote:
> > diff -Nurp ../gnumach/ddb/db_break.c ../gnumach1/ddb/db_break.c
>
> Please ease the life of maintainers by providing git-generated
> patches with a proper changelog entry.
>
No probl
On Wed, Jul 03, 2013 at 11:35:31AM +0200, Marin Ramesa wrote:
> diff -Nurp ../gnumach/ddb/db_break.c ../gnumach1/ddb/db_break.c
Please ease the life of maintainers by providing git-generated patches
with a proper changelog entry.
--
Richard Braun
When building with --enable-kdb.
* ddb/db_break.c: Include ddb/db_access.h.
* ddb/db_examine.h (db_xcdump): Add prototype.
* ddb/db_ext_symtab.c: Include vm/vm_user.h.
* ddb/db_input.c: Include device/cons.h.
* ddb/db_output.c: Likewise.
* ddb/db_command.c: Add extern _setjmp.
* ddb/db_cond.c: Like
13 matches
Mail list logo
