Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-24 Thread Diego Nieto Cid
On Tue, Dec 24, 2024 at 02:11:07PM -0300, Diego Nieto Cid wrote: > > I've been expanding the comment in gnumach.defs: > > /* > * Set a task virtual memory limit parameters > * > * HOST_PORT must be the privileged host control port > * if the caller desires t

Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-24 Thread Diego Nieto Cid
On Tue, Dec 24, 2024 at 12:44:49PM +0300, Sergey Bugaev wrote: > > + ASSERT(err == KERN_SUCCESS, "cannot set VM limits"); > > There's ASSERT_RET, which also stringifies the error code. > Good, that's much better. > > + /* check limits are actually saved */ > > + err = vm_get_size_limit(mac

Re: [PATCH Mach] kern: Comment fixed

2024-12-24 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le mar. 24 déc. 2024 10:44:17 +0800, a ecrit: > Read also: > https://mail.gnu.org/archive/html/bug-hurd/2024-12/msg00219.html > > Signed-off-by: Zhaoming Luo > --- > kern/mach_clock.c | 2 +- > kern/mach_clock.h | 2 +- > 2 files changed, 2 insertions(+), 2 deleti

Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-24 Thread Sergey Bugaev
Getting really close :) On Mon, Dec 23, 2024 at 10:07 PM wrote: > + > +/* > + * Set a task virtual memory limit parameters > + */ > +routine vm_set_size_limit( > + host_port : mach_port_t; > + map : vm_task_t; > + current_limit : vm_size_t; > + max_limit