Applied, thanks!
Zhaoming Luo, le ven. 08 nov. 2024 11:16:19 +0800, a ecrit:
> I don't think ioctls.h is a good place looking for the subsystem id
> calculation, instead hurd/ioctls.defs, it contains the following codes:
>
> ```
> /* Calculate the MiG subsystem (i.e. first message ID)
>for the
On Fri, Nov 8, 2024 at 4:55 AM Zhaoming Luo wrote:
> diff --git a/rtc/main.c b/rtc/main.c
> new file mode 100644
> index ..114fb497
> --- /dev/null
> +++ b/rtc/main.c
> @@ -0,0 +1,88 @@
> +
> +#include
> +
> +#include
> +#include
> +#include
I don't think you need nullauth.h?
> +#inc
Hi Zhaoming,
On Fri, Nov 8, 2024 at 11:01 AM Samuel Thibault wrote:
> Here as well this breaks the build since at this point of the series you
> haven't added rtc.h yet. Better just merge all the patches.
To expand on what Samuel says, the point is that the repo is expected
to build successfully
Zhaoming Luo, le ven. 08 nov. 2024 09:08:28 +0800, a ecrit:
> This v2 patch series applys Sergey's and Samuel's suggestions. The
> copyright headers have not been added because it is still work in
> progress.
Even work in progress can have copyright :)
Samuel
Zhaoming Luo, le ven. 08 nov. 2024 09:08:30 +0800, a ecrit:
> ---
> hurd/pioctl.defs | 34 ++
> 1 file changed, 34 insertions(+)
> create mode 100644 hurd/pioctl.defs
>
> diff --git a/hurd/pioctl.defs b/hurd/pioctl.defs
> new file mode 100644
> index ..144
Hello,
Better merge this with the 4th that actually adds something to build
there. Otherwise this commit breaks the build when doing e.g. git
bisect.
Actually, you can as well merge the 4 commits, since they go altogether.
But please keep using git format-patch, the format of your mails are as
ex
