Re: [PATCH gnumach 3/3] add rpc interrupted test

2024-08-22 Thread Samuel Thibault
Luca Dariz, le mer. 21 août 2024 18:36:16 +0200, a ecrit: > * tests/test-machmsg.c: add two use cases used by glibc during signal > handling > * tests/include/testlib.h > * tests/testlib.c: add new wait_thread_terminated() helper Applied, thanks! > --- > tests/include/testlib.h | 1 + > tests

Re: [PATCH v2 gnumach 1/3] add xfloat thread state interface

2024-08-22 Thread Samuel Thibault
Luca Dariz, le mer. 21 août 2024 18:36:14 +0200, a ecrit: > + } else if (flavor == i386_XFLOAT_STATE) { > + int i; > + struct i386_xfp_save *user_fp_state = (struct i386_xfp_save *) > &xfstate->hw_state[0]; We should also check that user_fp_state->fp_save_kind == f

Re: [PATCH v2 gnumach 1/3] add xfloat thread state interface

2024-08-22 Thread Samuel Thibault
Luca Dariz, le mer. 21 août 2024 18:36:14 +0200, a ecrit: > diff --git a/i386/include/mach/i386/mach_i386.defs > b/i386/include/mach/i386/mach_i386.defs > index 965d5c3b..61fed222 100644 > --- a/i386/include/mach/i386/mach_i386.defs > +++ b/i386/include/mach/i386/mach_i386.defs > @@ -111,3 +111,9

Re: [PATCH gnumach 2/3] add tests for FLOAT/XFLOAT state

2024-08-22 Thread Samuel Thibault
Luca Dariz, le mer. 21 août 2024 18:36:15 +0200, a ecrit: > +static void printx(struct i386_xfloat_state *state, int size) > +{ > + printf("xfloat init %d fp %d exc %d\n", > + state->initialized, state->fpkind, state->exc_status); > + struct i386_xfp_save *xfp = (struct i386_xfp_save *) &

Re: [PATCH v2 gnumach 1/3] add xfloat thread state interface

2024-08-22 Thread Samuel Thibault
Hello, Thanks for the improved version! Luca Dariz, le mer. 21 août 2024 18:36:14 +0200, a ecrit: > @@ -495,10 +534,11 @@ ASSERT_IPL(SPL0); > * concurrent fpu_set_state or fpu_get_state. > */ > kern_return_t > -fpu_get_state(const thread_t thread, > - struct i386_float_state *state