Re: [PATCH v2 gnumach] Add timing info to MACH_LOCK_MON lock monitoring

2023-08-04 Thread Samuel Thibault
Damien Zammit, le sam. 22 juil. 2023 04:50:50 +, a ecrit: > db{0}> show all slocks > > SUCCESS FAILMASKED STACK TIMELOCK/CALLER > 47082 0/0 47082/100 0/0 413940/80xc1098f54(c11847c8) > 2 0/0 2/100 0/0 413940/206970 0x6ede(c11966e0) > 47139

Re: [PATCH v2 gnumach] Add timing info to MACH_LOCK_MON lock monitoring

2023-08-04 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le sam. 22 juil. 2023 04:50:50 +, a ecrit: > Booting to beginning of bootstrap with different number of cpus > and checking the lock statistics where TIME is in milliseconds: > > Set MACH_LOCK_MON to 1 in configfrag.ac, then > > Configure options > --enable-n

Re: [PATCH gnumach] db_interface: Don't call db_on if MACH_KDB is off

2023-08-04 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le sam. 22 juil. 2023 04:50:27 +, a ecrit: > Allows building of gnumach with --disable-kdb and --enable-ncpus > 1 > --- > i386/i386/db_interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/i386/i386/db_interface.c b/i386/i386/db_

Re: [PATCH 5/5] x86_64: remove unneeded segment selectors handling on full 64 bit

2023-08-04 Thread Samuel Thibault
Luca Dariz, le sam. 29 juil. 2023 19:47:53 +0200, a ecrit: > @@ -803,10 +809,7 @@ kern_return_t thread_getstatus( > == 0) > saved_state->efl &= ~EFL_IF; > } > - } > - else > -#endif > - { >

Re: [PATCH 4/5] x86_64: refactor segment register handling

2023-08-04 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 29 juil. 2023 19:47:52 +0200, a ecrit: > The actual values are not saved together with the rest of the thread > state, both because it would be quite espensive (reading MSR, unless > rdfsbase instructions are supported, but that's optional) and not > really nee

Re: [PATCH 3/5] x86_64: format pusha/popa macros for readability

2023-08-04 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 29 juil. 2023 19:47:51 +0200, a ecrit: > --- > x86_64/locore.S | 37 +++-- > 1 file changed, 35 insertions(+), 2 deletions(-) > > diff --git a/x86_64/locore.S b/x86_64/locore.S > index 413d43c4..7127957b 100644 > --- a/x86_64/l

Re: [PATCH 2/5] x86_64: disable V86 mode on full 64-bit configuration

2023-08-04 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 29 juil. 2023 19:47:50 +0200, a ecrit: > * i386/i386/pcb.c: simplify exception stack location and adapt thread > gettrs/setters > * i386/i386/thread.h: don't include V86 fields on full 64-bit > * x86_64/locore.S: don't include checks for V86 mode on full 64-b

Re: [PATCH 1/5] x86_64: fix stack handling on recursive interrupts for USER32

2023-08-04 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 29 juil. 2023 19:47:49 +0200, a ecrit: > * x86_64/locore.S: ensure the thread state is filled completely even > on recursive interrups. The value of the segment selectors is not > very important in this case, but we still need to align the stack to > the

Re: [PATCH v2] x86_64: install emergency handler for double fault

2023-08-04 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 29 juil. 2023 19:45:14 +0200, a ecrit: > * i386/i386/idt.c: add selector for the interrupt-specific stack > * i386/i386/ktss.c: configure ist1 to use a dedicated stack > * i386/i386/trap.c: add double fault handler, which just prints the > state and panics. T