Recent patches break ACPI tables

2023-06-17 Thread Damien Zammit
Hi, Almu and I discovered that the following commit breaks --enable-apic --enable-ncpus= >1 --disable-linux-groups * d972c01c pmap: only map lower BIOS memory 1:1 when using Linux drivers I believe the ACPI tables need temporary low memory mapping to access them. Also, the commit: * 54a4ca2

Re: [PATCH] Fix copying in MACH_PORT_DEAD on x86_64

2023-06-17 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le jeu. 15 juin 2023 21:17:31 +0300, a ecrit: > We need to properly convert MACH_PORT_NAME_DEAD (which is 32-bit -1) > into IO_DEAD, which is 64-bit -1. > > To reproduce: > > $ portinfo -va 1 > (see the Mach crash trying to access a port at 0x) > --- > ip

Re: [PATCH 3/3] x86_64: add a critical section on entry and exit from syscall/sysret

2023-06-17 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le jeu. 15 juin 2023 23:49:31 +0200, a ecrit: > When entering a syscall we're still using the user stack, so we can't > reliably handle exceptions or interrupts, otherwise a user thread can > easily crash the machine with an invalid stack. Instead, disable > interrupts

Re: [PATCH 2/3] x86_64: install emergency handler for double fault

2023-06-17 Thread Samuel Thibault
Luca Dariz, le jeu. 15 juin 2023 23:49:30 +0200, a ecrit: > diff --git a/i386/i386/ktss.c b/i386/i386/ktss.c > index 1d880167..52f3722c 100644 > --- a/i386/i386/ktss.c > +++ b/i386/i386/ktss.c > @@ -61,6 +61,7 @@ ktss_fill(struct task_tss *myktss, struct real_descriptor > *mygdt) > /* Initia

Re: [PATCH 1/3] x86_64: use solid intstack already during bootstrap

2023-06-17 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le jeu. 15 juin 2023 23:49:29 +0200, a ecrit: > * x86_64/boothdr.S: there is no reason to not use it right away > --- > x86_64/boothdr.S | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/x86_64/boothdr.S b/x86_64/boothdr.S > index d81f9a78.

Re: [PATCH] Remove error procedure directives

2023-06-17 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le sam. 17 juin 2023 23:39:53 +0300, a ecrit: > Back in the wonderful old days of Mach 2, when there were no send-once > rights, dead names, or port reference counts, MIG used to have more > kinds of operations: there were functions, procedures, simpleprocedures, >

[PATCH] Remove error procedure directives

2023-06-17 Thread Sergey Bugaev
Back in the wonderful old days of Mach 2, when there were no send-once rights, dead names, or port reference counts, MIG used to have more kinds of operations: there were functions, procedures, simpleprocedures, routines, and simpleroutines. Routines returned an error code as their C function retur

Re: [PATCH v3 2/2] Use O_IGNORE_CTTY where appropriate

2023-06-17 Thread Paul Eggert
On 2023-06-16 09:26, Sergey Bugaev wrote: Hello, So how about this? "Cause operations on the new file descriptor to act as if the named file is not the process's controlling terminal, even if it is. @xref{Job Control}. When @code{O_IGNORE_CTTY} is not set, @code{open} has to perform a runtim