Re: [PATCH gnumach] Implement mig_deallocate to free memory when kernel server RPC succeeds

2023-05-01 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le lun. 01 mai 2023 22:52:19 -0400, a ecrit: > In case the kernel interfaces use dynamically sized strings, we will > end up calling mig_deallocate to free the out of line string that was copied > into the kernel. As a matter of contract such type of data is freed > a

Re: [PATCH gnumach] Use mig_support.h prototypes instead of duplicating them.

2023-05-01 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le lun. 01 mai 2023 21:10:42 -0400, a ecrit: > * include/mach/mig_support.h: Drop the ifndef because this file is only > used internally to compile gnumach. We export mig_support.h from glibc > already. > * kern/ipc_mig.c: len should be vm_size_t. > * kern/ipc_mig

Re: [PATCH hurd] Use uintptr_t for message payloads.

2023-05-01 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le mar. 02 mai 2023 00:11:22 -0400, a ecrit: > A follow up to 92fad38a043b75ed6b435b3efa574ede91dbe9ee in gnumach. > --- > auth/mig-decls.h| 2 +- > eth-multiplexer/mig-decls.h | 2 +- > exec/mig-decls.h| 2 +- > libcons/priv.h

[PATCH hurd] Use uintptr_t for message payloads.

2023-05-01 Thread Flavio Cruz
A follow up to 92fad38a043b75ed6b435b3efa574ede91dbe9ee in gnumach. --- auth/mig-decls.h| 2 +- eth-multiplexer/mig-decls.h | 2 +- exec/mig-decls.h| 2 +- libcons/priv.h | 2 +- libdiskfs/diskfs.h | 12 ++-- libmachdev/mig-decls.h |

[PATCH gnumach] Implement mig_deallocate to free memory when kernel server RPC succeeds

2023-05-01 Thread Flavio Cruz
In case the kernel interfaces use dynamically sized strings, we will end up calling mig_deallocate to free the out of line string that was copied into the kernel. As a matter of contract such type of data is freed automatically either in kernel code when the RPC fails or in the MiG stub if it succe

[PATCH gnumach] Use mig_support.h prototypes instead of duplicating them.

2023-05-01 Thread Flavio Cruz
* include/mach/mig_support.h: Drop the ifndef because this file is only used internally to compile gnumach. We export mig_support.h from glibc already. * kern/ipc_mig.c: len should be vm_size_t. * kern/ipc_mig.h: Drop duplicate prototypes. --- include/mach/mig_support.h | 4 +--- kern/ipc_mig.

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Cristian Rodríguez
a On Sat, Apr 29, 2023 at 9:12 AM Sergey Bugaev via Libc-alpha < libc-al...@sourceware.org> wrote: > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror () and similar > functions. > abort() and all the function wrappers called by

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Samuel Thibault
Cristian Rodríguez, le lun. 01 mai 2023 17:52:17 -0400, a ecrit: > On Sat, Apr 29, 2023 at 9:12 AM Sergey Bugaev via Libc-alpha <[1] > libc-al...@sourceware.org> wrote: > > GCC docs explicitly list perror () as a good candidate for using > __attribute__ ((cold)). So apply __COLD to perror

Re: [PATCH v3 4/6] hurd: Add expected abilist files for x86_64

2023-05-01 Thread Samuel Thibault
Sergey Bugaev, le lun. 01 mai 2023 20:33:36 +0300, a ecrit: > On Mon, May 1, 2023 at 1:20 PM Samuel Thibault > wrote: > > Applied, thanks! > > I assume the delay means you have built it, and your results matched > mine, Yes :) Though I added libanl which we do want since we haven't moved libpt

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Samuel Thibault
Siddhesh Poyarekar, le lun. 01 mai 2023 12:15:04 -0400, a ecrit: > > > On 2023-04-29 11:06, Samuel Thibault via Libc-alpha wrote: > > It looks sensible to me indeed, any opinion from somebody else? > > > > > > > > > > Sergey Bugaev, le sam. 29 avril 2023 16:12:23 +0300, a ecrit: > > > GCC doc

Re: [PATCH v3 4/6] hurd: Add expected abilist files for x86_64

2023-05-01 Thread Sergey Bugaev
On Mon, May 1, 2023 at 1:20 PM Samuel Thibault wrote: > Applied, thanks! I assume the delay means you have built it, and your results matched mine, in which case, \o/ I can hardly believe it no longer only exists on my machine :) Did you manage to run it? Thank you for changing pthread_t to be

Re: [PATCH 3/3] Mark various cold functions as __COLD

2023-05-01 Thread Siddhesh Poyarekar
On 2023-04-29 11:06, Samuel Thibault via Libc-alpha wrote: It looks sensible to me indeed, any opinion from somebody else? Sergey Bugaev, le sam. 29 avril 2023 16:12:23 +0300, a ecrit: GCC docs explicitly list perror () as a good candidate for using __attribute__ ((cold)). So apply __COLD

Re: [hurd, commited] socket: Fix tst-cmsghdr-skeleton.c use of cmsg_len

2023-05-01 Thread Samuel Thibault
Andreas Schwab, le lun. 01 mai 2023 16:03:32 +0200, a ecrit: > On Mai 01 2023, Samuel Thibault wrote: > > > Andreas Schwab, le lun. 01 mai 2023 15:38:45 +0200, a ecrit: > >> On Mai 01 2023, Samuel Thibault wrote: > >> > >> > cmsg_len is supposed to be socklen_t according to standards, but it was

Re: [hurd, commited] socket: Fix tst-cmsghdr-skeleton.c use of cmsg_len

2023-05-01 Thread Andreas Schwab
On Mai 01 2023, Samuel Thibault wrote: > Andreas Schwab, le lun. 01 mai 2023 15:38:45 +0200, a ecrit: >> On Mai 01 2023, Samuel Thibault wrote: >> >> > cmsg_len is supposed to be socklen_t according to standards, but it was >> > made >> > size_t on Linux, see BZ 16919. For ports that have it soc

[RFC, hurd 64bit]: st_dev type

2023-05-01 Thread Samuel Thibault
Hello, Since we are creating a new ABI, it's time to take care of types :) I have fixed a few cases that had been identified on hurd 32bit, so that hurd 64bit doesn't get affected. There is however one case which remains problematic: stat.st_dev, which the standars say to have type dev_t, is #de

Re: [hurd, commited] socket: Fix tst-cmsghdr-skeleton.c use of cmsg_len

2023-05-01 Thread Samuel Thibault
Andreas Schwab, le lun. 01 mai 2023 15:38:45 +0200, a ecrit: > On Mai 01 2023, Samuel Thibault wrote: > > > cmsg_len is supposed to be socklen_t according to standards, but it was made > > size_t on Linux, see BZ 16919. For ports that have it socklen_t, SIZE_MAX is > > too large. We can however ex

Re: [hurd, commited] socket: Fix tst-cmsghdr-skeleton.c use of cmsg_len

2023-05-01 Thread Andreas Schwab
On Mai 01 2023, Samuel Thibault wrote: > cmsg_len is supposed to be socklen_t according to standards, but it was made > size_t on Linux, see BZ 16919. For ports that have it socklen_t, SIZE_MAX is > too large. We can however explicitly cast it to the type of cmsg_len so it > will fit according to

Re: [PATCH v3 4/6] hurd: Add expected abilist files for x86_64

2023-05-01 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le sam. 29 avril 2023 23:18:20 +0300, a ecrit: > These were created by creating stub files, running 'make update-abi', > and reviewing the results. > > Also, set baseline ABI to GLIBC_2.38, the (upcoming) first glibc > release to first have x86_64-gnu support. > >