Re: [RFC PATCH gnumach 03/34] Make exception subcode a long

2023-04-10 Thread Samuel Thibault
Hello, Flávio Cruz, le mer. 05 avril 2023 22:11:38 -0400, a ecrit: > On Mon, Apr 3, 2023 at 5:32 AM Sergey Bugaev via Libc-alpha <[1] > libc-al...@sourceware.org> wrote: > > On Mon, Apr 3, 2023 at 1:45 AM Samuel Thibault > <[2]samuel.thiba...@gnu.org> > wrote: > > Sergey Bugaev, le d

Re: GDB breakpoints are broken in new threads -- here's why

2023-04-10 Thread Samuel Thibault
Hello, Sergey Bugaev, le dim. 02 avril 2023 15:22:33 +0300, a ecrit: > I propose the following: before resetting the exception port, glibc > would fetch the previous one, and if it's non-null, it will perform a > special synchronous RPC on it, both passing the new exception port > that it would se

Re: [RFC PATCH glibc 26/34] hurd: Remove __hurd_local_reply_port

2023-04-10 Thread Samuel Thibault
Samuel Thibault, le mar. 11 avril 2023 00:07:43 +0200, a ecrit: > Sergey Bugaev, le dim. 19 mars 2023 18:10:09 +0300, a ecrit: > > /* Called by MiG to deallocate the reply port. */ > > void > > -__mig_dealloc_reply_port (mach_port_t arg) > > +__mig_dealloc_reply_port (mach_port_t port) > > { >

Re: [RFC PATCH glibc 27/34] hurd: Don't leak __hurd_reply_port0

2023-04-10 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:10:10 +0300, a ecrit: > Previously, once we set up TLS, we would implicitly switch from using > __hurd_reply_port0 to reply_port inside the TCB, leaving the former > unused. But we never deallocated it, so it got leaked. > > Instead, migrate

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Samuel Thibault
Sergey Bugaev, le mar. 11 avril 2023 00:50:25 +0300, a ecrit: > On Mon, Apr 10, 2023 at 10:22 PM Samuel Thibault > wrote: > > > > Sergey Bugaev, le lun. 10 avril 2023 22:13:06 +0300, a ecrit: > > > On Mon, Apr 10, 2023 at 9:58 PM Samuel Thibault > > > wrote: > > > > > > > > Sergey Bugaev, le dim

Re: [RFC PATCH glibc 26/34] hurd: Remove __hurd_local_reply_port

2023-04-10 Thread Samuel Thibault
Sergey Bugaev, le dim. 19 mars 2023 18:10:09 +0300, a ecrit: > /* Called by MiG to deallocate the reply port. */ > void > -__mig_dealloc_reply_port (mach_port_t arg) > +__mig_dealloc_reply_port (mach_port_t port) > { > - mach_port_t port = __hurd_local_reply_port; > - __hurd_local_reply_port

Re: [RFC PATCH glibc 25/34] hurd: Improve reply port handling when exiting signal handlers

2023-04-10 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:10:08 +0300, a ecrit: > NOTE: I don't really understand why sigunwind wants to destroy both its > current reply port and user's reply port. Prior to commit > fb304035c41c7ee2afede51e5e8568974549ba5e, it was *restoring* the user's > reply port

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Sergey Bugaev
On Mon, Apr 10, 2023 at 10:22 PM Samuel Thibault wrote: > > Sergey Bugaev, le lun. 10 avril 2023 22:13:06 +0300, a ecrit: > > On Mon, Apr 10, 2023 at 9:58 PM Samuel Thibault > > wrote: > > > > > > Sergey Bugaev, le dim. 19 mars 2023 18:09:59 +0300, a ecrit: > > > > +#ifdef __USE_GNU > > > > +/*

Re: [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization inside rtld or in static builds

2023-04-10 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:10:07 +0300, a ecrit: > When glibc is built as a shared library, TLS is always initialized by > the call of TLS_INIT_TP () macro made inside the dynamic loader, prior > to running the main program (see dl-call_tls_init_tp.h). We can take > ad

Re: [PATCH v2 18.2/34] hurd: Port trampoline.c to x86_64

2023-04-10 Thread Sergey Bugaev
On Mon, Apr 10, 2023 at 10:04 PM Samuel Thibault wrote: > Sergey Bugaev, le lun. 03 avril 2023 14:56:21 +0300, a ecrit: > > @@ -110,6 +132,10 @@ _hurd_setup_sighandler (struct hurd_sigstate *ss, > > const struct sigaction *action > > ucontext_t *uctxp;/* Points to uctx, be

Re: [RFC PATCH 00/34] The rest of the x86_64-gnu port

2023-04-10 Thread Samuel Thibault
Sergey Bugaev, le mar. 11 avril 2023 00:24:55 +0300, a ecrit: > On Mon, Apr 10, 2023 at 10:20 PM Samuel Thibault > wrote: > > > > Sergey Bugaev, le dim. 19 mars 2023 18:09:43 +0300, a ecrit: > > > As for sigreturn specifically: I'm concerned about the possibility that > > > putting the register du

Re: [RFC PATCH glibc 23/34] elf: Stop including tls.h in ldsodefs.h

2023-04-10 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > Nothing in there needs tls.h > > Signed-off-by: Sergey Bugaev > --- > sysdeps/generic/ldsodefs.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > ind

Re: [RFC PATCH 00/34] The rest of the x86_64-gnu port

2023-04-10 Thread Sergey Bugaev
On Mon, Apr 10, 2023 at 10:20 PM Samuel Thibault wrote: > > Sergey Bugaev, le dim. 19 mars 2023 18:09:43 +0300, a ecrit: > > As for sigreturn specifically: I'm concerned about the possibility that > > putting the register dump onto the user's stack (or at %rsp - 128, on > > x86_64) > > may clobbe

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Samuel Thibault
Sergey Bugaev, le lun. 10 avril 2023 22:13:06 +0300, a ecrit: > On Mon, Apr 10, 2023 at 9:58 PM Samuel Thibault > wrote: > > > > Sergey Bugaev, le dim. 19 mars 2023 18:09:59 +0300, a ecrit: > > > +#ifdef __USE_GNU > > > +/* Number of each register in the `gregset_t' array. */ > > > +enum > > > +

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Samuel Thibault
Sergey Bugaev, le lun. 10 avril 2023 22:07:33 +0300, a ecrit: > On Mon, Apr 10, 2023, 21:39 Samuel Thibault wrote: > > Note that I have pushed sysdeps/mach/hurd/x86_64/sys/ucontext.h to > > sysdeps/x86_64/sys/ucontext.h since it's not mach-specific, and Linux > > has its own for x86. > > It's not

Re: [RFC PATCH 00/34] The rest of the x86_64-gnu port

2023-04-10 Thread Samuel Thibault
Hello, Sergey Bugaev, le dim. 19 mars 2023 18:09:43 +0300, a ecrit: > As for sigreturn specifically: I'm concerned about the possibility that > putting the register dump onto the user's stack (or at %rsp - 128, on x86_64) > may clobber the data trampoline.c puts there (unless an altstack is used),

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Sergey Bugaev
On Mon, Apr 10, 2023 at 9:58 PM Samuel Thibault wrote: > > Sergey Bugaev, le dim. 19 mars 2023 18:09:59 +0300, a ecrit: > > +#ifdef __USE_GNU > > +/* Number of each register in the `gregset_t' array. */ > > +enum > > +{ > > + REG_GSFS = 0, /* Actually int gs, fs. */ > > +# define R

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Sergey Bugaev
On Mon, Apr 10, 2023, 21:39 Samuel Thibault wrote: > > Hello, > > Applied, thanks! Yay! Thank you for finding the time to review some more patches! Here's to hoping that the rest will follow. > Note that I have pushed sysdeps/mach/hurd/x86_64/sys/ucontext.h to > sysdeps/x86_64/sys/ucontext.h sin

Re: [PATCH v2 18.2/34] hurd: Port trampoline.c to x86_64

2023-04-10 Thread Samuel Thibault
This will possibly need to be fixed according to the FSGS regset change. Sergey Bugaev, le lun. 03 avril 2023 14:56:21 +0300, a ecrit: > @@ -110,6 +132,10 @@ _hurd_setup_sighandler (struct hurd_sigstate *ss, const > struct sigaction *action > ucontext_t *uctxp;/* Points to

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Samuel Thibault
Sergey Bugaev, le dim. 19 mars 2023 18:09:59 +0300, a ecrit: > +#ifdef __USE_GNU > +/* Number of each register in the `gregset_t' array. */ > +enum > +{ > + REG_GSFS = 0, /* Actually int gs, fs. */ > +# define REG_GSFSREG_GSFS > + REG_ESDS, /* Actually int es, ds. */

Re: [PATCH v2 18.1/34] hurd: Do not declare local variables volatile

2023-04-10 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le lun. 03 avril 2023 14:56:20 +0300, a ecrit: > These are just regular local variables that are not accessed in any > funny ways, not even though a pointer. There's absolutely no reason to > declare them volatile. It only ends up hurting the quality of the > genera

Re: [RFC PATCH glibc 17/34] hurd: Implement x86_64/intr-msg.h

2023-04-10 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:10:00 +0300, a ecrit: > This is a prelimenary version of intr-msg.h. I can't know whether or not > it works until we can test it. Sure :) > The code relies on syscall preserving values > of the registers used to pass syscall arguments. The

Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

2023-04-10 Thread Samuel Thibault
Hello, Applied, thanks! Note that I have pushed sysdeps/mach/hurd/x86_64/sys/ucontext.h to sysdeps/x86_64/sys/ucontext.h since it's not mach-specific, and Linux has its own for x86. Samuel Sergey Bugaev, le dim. 19 mars 2023 18:09:59 +0300, a ecrit: > This is based on the Linux port's version,

Re: [PATCH glibc] Stop depending on the default_pager stubs provided by gnumach

2023-04-10 Thread Samuel Thibault
Applied, thanks! Flavio Cruz via Libc-alpha, le dim. 09 avril 2023 22:42:52 -0400, a ecrit: > The hurd source tree already provides the same stubs and they are only > needed there. > --- > sysdeps/mach/configure| 3 +-- > sysdeps/mach/configure.ac | 3 +-- > 2 files changed, 2 insertions(+),

Re: [PATCH gnumach] Delete include/mach/default_pager_helper.defs

2023-04-10 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 09 avril 2023 22:35:10 -0400, a ecrit: > Not used. > --- > Makefrag.am| 1 - > include/mach/default_pager_helper.defs | 53 -- > 2 files changed, 54 deletions(-) > delete mode 100644 include/mach/default_p

/hurd/random warning during install

2023-04-10 Thread jbranso
So I re-installed the base system of the Hurd on my T43 just now. It installer worked really well! The installer did give me this warning: /hurd/random: Warning: Failed to read random seed file /var/lib/random-seed: (System Kern) error with unknown subsystem Just an FYI, Joshua