Re: [PATCH glibc] Remove sysdeps/mach/i386/machine-sp.h

2023-02-02 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le jeu. 02 févr. 2023 02:42:18 -0500, a ecrit: > This file is not used today since we end up using > sysdeps/i386/htl/machine-sp.h. Getting the stack pointer does not need > to be hurd specific and can go into sysdeps/. > --- > sysdeps/mach/i386/machine-sp.h | 30 ---

Re: [PATCH mig] Do not generate the server routine for kernel servers.

2023-02-02 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le jeu. 02 févr. 2023 02:41:52 -0500, a ecrit: > The kernel does not use these functions so we can avoid a few compiler > warnings. I think we could make the hurd servers not use these also but > currently these are still needed. > --- > server.c | 94 +++

Re: [PATCH 2/5 gnumach] i386: Refactor int stacks to be per cpu for SMP

2023-02-02 Thread Almudena Garcia
I already suggested move this to a function +#ifndef MACH_HYP +/* Turn paging on. + * TODO: Why does setting the WP bit here cause a crash? + */ +set_cr0(get_cr0() | CR0_PG /* | CR0_WP */); +set_cr0(get_cr0() & ~(CR0_CD | CR0_NW)); +if (CPU_HAS_FEATURE(CPU_FEATURE_PGE)) +