Re: [PATCH 5/5 rumpkernel] pci-userspace: Add acpi lookup of irqs

2022-09-05 Thread Samuel Thibault
Damien Zammit, le dim. 04 sept. 2022 03:47:38 +, a ecrit: > This depends on having installed. > > It will now fail to run if acpi translator is not running as it needs > the actual pci irq. > > --- > debian/patches/acpi.diff | 74 > debian/patches/se

Re: [PATCH 4/5] acpi: Remove references to /dev/mem

2022-09-05 Thread Samuel Thibault
Nice :) Damien Zammit, le dim. 04 sept. 2022 03:47:24 +, a ecrit: > --- > acpi/acpi.c | 109 > 1 file changed, 34 insertions(+), 75 deletions(-) > > diff --git a/acpi/acpi.c b/acpi/acpi.c > index 9827232a..dd32d60f 100644 > --- a/acpi/acpi

Re: [PATCH 3/5] acpi: Convert translator to an emulated mach device

2022-09-05 Thread Samuel Thibault
Please also mention in the commit log that it's meant to make it usable as bootstrap translator. Damien Zammit, le dim. 04 sept. 2022 03:47:19 +, a ecrit: > diff --git a/acpi/acpifs.c b/acpi/acpifs.c > index 2b5fbc00..75cc2e28 100644 > --- a/acpi/acpifs.c > +++ b/acpi/acpifs.c > @@ -106,18 +10

Re: [PATCH 2/5] shutdown: Use new acpi RPC to halt machine, clean up

2022-09-05 Thread Samuel Thibault
Damien Zammit, le dim. 04 sept. 2022 03:47:14 +, a ecrit: > This allows clean shutdown of all modern x86 machines > (not just qemu) by using the acpi translator to call > into libacpica code. Way less hardcoded :D > diff --git a/shutdown/shutdown.c b/shutdown/shutdown.c > index f821b1f2..a4cc

Re: [PATCH 1/5] acpi: Link translator to libacpica and provide RPCs

2022-09-05 Thread Samuel Thibault
Damien Zammit, le dim. 04 sept. 2022 03:47:09 +, a ecrit: > Provides two new acpi RPCs to sleep the machine and > to get the irq of any pci device. ACPI mode is enabled > by default when the translator is started. > > NB: Merging this commit means libacpica is a build dep. Please then make t

Re: [PATCH v2 2/2] procfs: Populate /proc/route with network routes

2022-09-05 Thread Samuel Thibault
Hello, The principe looks good, just a few comments below. Samuel Damien Zammit, le ven. 02 sept. 2022 09:06:38 +, a ecrit: > diff --git a/procfs/rootdir.c b/procfs/rootdir.c > index 0e7c05c00..deddaa43f 100644 > --- a/procfs/rootdir.c > +++ b/procfs/rootdir.c > @@ -408,6 +411,70 @@ out: >

Re: [PATCH v2 1/2] Add new RPC for pfinet network routes

2022-09-05 Thread Samuel Thibault
Hello, The principle looks good, here are some comments. Samuel Damien Zammit, le ven. 02 sept. 2022 09:06:33 +, a ecrit: > diff --git a/pfinet/linux-src/net/ipv4/fib_hash.c > b/pfinet/linux-src/net/ipv4/fib_hash.c > index 074a36876..ca25377c9 100644 > --- a/pfinet/linux-src/net/ipv4/fib_ha