[PATCH v2] startup: Mark essential tasks as our children

2021-06-05 Thread Damien Zammit
This boots, but proc_child(fs) is needed in launch_core_servers otherwise it hangs at " auth" --- startup/startup.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/startup/startup.c b/startup/startup.c index 9faeb462..2499f81d 100644 --- a/startup/startup.c

Re: [PATCH 2/2] proc/info: Fix EIO with /proc/6/stat

2021-06-05 Thread Samuel Thibault
I don't think we want to "fix" it like this, this is very probably only papering over an actual issue that could bite another way. We need to find out the root issue, rather than circumvent it. I see on IRC that you mention that you have a NULL string pointer, which results in an ESRCH error here

Re: [PATCH 1/2] startup: Mark essential tasks as our children

2021-06-05 Thread Samuel Thibault
As I already requested, please additionally try to remove err = proc_child (procserver, fstask); err = proc_child (procserver, authtask); from launch_core_servers. Otherwise they will be duplicates and bring confusion to the next reader of the code. Samuel Damien Zammit, le sam. 05 juin 2021 20

[PATCH 1/2] startup: Mark essential tasks as our children

2021-06-05 Thread Damien Zammit
--- startup/startup.c | 4 1 file changed, 4 insertions(+) diff --git a/startup/startup.c b/startup/startup.c index 9faeb462..78d69103 100644 --- a/startup/startup.c +++ b/startup/startup.c @@ -368,6 +368,10 @@ record_essential_task (const char *name, task_t task) /* Dead-name notificatio

[PATCH 2/2] proc/info: Fix EIO with /proc/6/stat

2021-06-05 Thread Damien Zammit
--- proc/info.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/proc/info.c b/proc/info.c index 6c2567d2..9c5d3543 100644 --- a/proc/info.c +++ b/proc/info.c @@ -316,7 +316,10 @@ get_string_array (task_t t, err = get_vector (t, loc, &vector); if (err) -return er