Re: [PATCH x2: gnumach] - More IOAPIC fixes

Damien Zammit, le lun. 05 avril 2021 21:59:19 +1000, a ecrit: > Here are two more patches, one fixes a bug where a return value > was from the stack and missing the top half of the value! > > The other patch refactors the EOI to simplify the asm code > in interrupt.S Applied, thanks!

[PATCH 2/2] ioapic: Fix arg passing of redirection entry

--- i386/i386at/ioapic.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/i386/i386at/ioapic.c b/i386/i386at/ioapic.c index 4d0f4fca..18a9bec6 100644 --- a/i386/i386at/ioapic.c +++ b/i386/i386at/ioapic.c @@ -114,15 +114,15 @@ ioapic_write(uint8_t id, uint8_t reg, u

[PATCH x2: gnumach] - More IOAPIC fixes

Here are two more patches, one fixes a bug where a return value was from the stack and missing the top half of the value! The other patch refactors the EOI to simplify the asm code in interrupt.S

[PATCH 1/2] ioapic: Refactor EOI

--- i386/i386/irq.c | 1 - i386/i386at/interrupt.S | 1 - i386/i386at/ioapic.c| 2 ++ x86_64/interrupt.S | 1 - 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/i386/i386/irq.c b/i386/i386/irq.c index 42921617..a7c98890 100644 --- a/i386/i386/irq.c +++ b/i386/i386/ir

Re: [PATCH x4 gnumach: IOAPIC fixes]

Applied, thanks! Damien Zammit, le lun. 05 avril 2021 15:29:12 +1000, a ecrit: > [PATCH 1/4] ioapic: Enable processor focus to BSP > [PATCH 2/4] ioapic: target first processor for interrupts > [PATCH 3/4] Don't call EOI on spurious interrupts > > These three patches are pretty much no-brainers fo