[PATCH] Add ioapic support disabled by default

2021-04-03 Thread Damien Zammit
Use --enable-ncpus=x --enable-apic where x > 1 for SMP+APIC support. Use neither for no SMP and old PIC support. --- i386/Makefrag.am | 13 +- i386/configfrag.ac | 8 + i386/i386/fpu.c | 2 +- i386/i386/irq.c | 9 +- i386/i386

Re: [PATCH 2/2] machdev: Pass argv through to _hurd_init

2021-04-03 Thread Damien Zammit
On 4/4/21 8:49 am, Samuel Thibault wrote: > Samuel Thibault, le sam. 27 mars 2021 23:27:20 +0100, a ecrit: >> Samuel Thibault, le sam. 20 mars 2021 00:03:21 +0100, a ecrit: >>> Damien Zammit, le ven. 19 mars 2021 13:15:12 +1100, a ecrit: +mach_port_t *bootstrap, char **argv

[PATCH] machdev: Pass argv through to _hurd_init

2021-04-03 Thread Damien Zammit
--- libmachdev/machdev.h | 2 +- libmachdev/trivfs_server.c | 11 +++ pci-arbiter/main.c | 2 +- rumpdisk/main.c| 2 +- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libmachdev/machdev.h b/libmachdev/machdev.h index 8f613b35..5d0eed02 100644 -

Re: [PATCH 2/2] machdev: Pass argv through to _hurd_init

2021-04-03 Thread Samuel Thibault
Samuel Thibault, le sam. 27 mars 2021 23:27:20 +0100, a ecrit: > Samuel Thibault, le sam. 20 mars 2021 00:03:21 +0100, a ecrit: > > Damien Zammit, le ven. 19 mars 2021 13:15:12 +1100, a ecrit: > > > +mach_port_t *bootstrap, char **argv) > > > > While at it, please add argc as w

Re: [PATCH 2/2] ioapic support switchable back to pic

2021-04-03 Thread Samuel Thibault
Damien Zammit, le mar. 30 mars 2021 13:58:30 +1100, a ecrit: > +val = (inb(PITAUX_PORT) & 0xfd) | 0x1; Rather use val &= ~PITAUX_OUT2; val |= PITAUX_GATE2; > +outb(PITAUX_PORT, val); > +outb(PITCTL_PORT, 0xb2); Use PIT_C2|PIT_LOADMODE|PIT_RATEMODE. > +val = CLKNUM / hz; > +l

Re: [PATCH 2/2] ioapic support switchable back to pic

2021-04-03 Thread Samuel Thibault
Damien Zammit, le mar. 30 mars 2021 13:58:30 +1100, a ecrit: > +AC_ARG_ENABLE([apic], > + AS_HELP_STRING([--enable-apic], [LAPIC/IOAPIC support (ix86-only); enabled > by default])) I don't think we want to enable it by default for now :) (that will allow to just commit the support and be done wi

Re: [PATCH 3/5] libacpica: Add acpi_init

2021-04-03 Thread Samuel Thibault
Samuel Thibault, le sam. 03 avril 2021 15:09:47 +0200, a ecrit: > Damien Zammit, le dim. 04 avril 2021 00:00:56 +1100, a ecrit: > > >> +acpi_status > > >> +acpi_os_wait_semaphore(acpi_semaphore handle, u32 units, u16 timeout) > > >> +{ > > >> +int i; > > >> + > > >> +if (!timeout) >

Re: [PATCH 3/5] libacpica: Add acpi_init

2021-04-03 Thread Samuel Thibault
Damien Zammit, le dim. 04 avril 2021 00:00:56 +1100, a ecrit: > >> +acpi_status > >> +acpi_os_wait_semaphore(acpi_semaphore handle, u32 units, u16 timeout) > >> +{ > >> + int i; > >> + > >> + if (!timeout) > >> + timeout = 1; > >> + > >> + for (i = 0; i < timeout; i++) { > >> +

Re: [PATCH 3/5] libacpica: Add acpi_init

2021-04-03 Thread Damien Zammit
On 3/4/21 11:49 pm, Samuel Thibault wrote: > Damien Zammit, le sam. 03 avril 2021 23:16:33 +1100, a ecrit: >> +acpi_status >> +acpi_os_create_lock(acpi_spinlock *lockp) >> +{ >> +acpi_semaphore sema = NULL; >> +if (acpi_os_create_semaphore(1, 0, &sema) == AE_OK) { >> +*lockp = s

Re: [PATCH 3/5] libacpica: Add acpi_init

2021-04-03 Thread Samuel Thibault
Damien Zammit, le sam. 03 avril 2021 23:16:33 +1100, a ecrit: > +acpi_status > +acpi_os_create_lock(acpi_spinlock *lockp) > +{ > + acpi_semaphore sema = NULL; > + if (acpi_os_create_semaphore(1, 0, &sema) == AE_OK) { > + *lockp = sema; No, directly pass lockp to acpi_os_create_

Re: [PATCH 2/5] libacpica: Add config for GNU

2021-04-03 Thread Samuel Thibault
Samuel Thibault, le sam. 03 avril 2021 14:41:59 +0200, a ecrit: > Damien Zammit, le sam. 03 avril 2021 23:16:32 +1100, a ecrit: > > +#define acpi_semaphore sem_t* > > ? Rather a sem_t, no ? Otherwise you have to uselessly handle > allocations etc. while the caller can do it.

Re: [PATCH 2/5] libacpica: Add config for GNU

2021-04-03 Thread Samuel Thibault
Damien Zammit, le sam. 03 avril 2021 23:16:32 +1100, a ecrit: > +#define acpi_semaphore sem_t* > +#define acpi_spinlock sem_t* ? Rather a sem_t, no ? Otherwise you have to uselessly handle allocations etc. while the caller can do it. Samuel

[PATCH 4/5] acpi: Add acpi_init to server to initialize ACPI

2021-04-03 Thread Damien Zammit
--- acpi/Makefile | 2 +- acpi/main.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/acpi/Makefile b/acpi/Makefile index f84f4b35..49c8ba9a 100644 --- a/acpi/Makefile +++ b/acpi/Makefile @@ -25,7 +25,7 @@ SRCS = main.c netfs_impl.c acpi.c \ MIGSRCS= O

[PATCH 3/5] libacpica: Add acpi_init

2021-04-03 Thread Damien Zammit
--- libacpica/acpi_init.c | 612 ++ libacpica/acpi_init.h | 10 + 2 files changed, 622 insertions(+) create mode 100644 libacpica/acpi_init.c create mode 100644 libacpica/acpi_init.h diff --git a/libacpica/acpi_init.c b/libacpica/acpi_init.c new file mod

[PATCH 2/5] libacpica: Add config for GNU

2021-04-03 Thread Damien Zammit
--- libacpica/acpi/platform/acenv.h | 3 + libacpica/acpi/platform/acenvex.h | 3 + libacpica/acpi/platform/acgnu.h | 159 ++ libacpica/acpi/platform/acgnuex.h | 52 ++ 4 files changed, 217 insertions(+) create mode 100644 libacpica/acpi/platform/acgnu

[PATCH 5/5] acpi: Add new RPCs

2021-04-03 Thread Damien Zammit
--- acpi/Makefile| 15 - acpi/acpi-ops.c | 146 +++ acpi/acpi.h | 6 ++ acpi/main.c | 4 +- acpi/mig-mutate.h| 28 + hurd/acpi.defs | 60 ++ hurd/hurd_types.defs | 18 ++ hurd/h

[PATCH 1/5] libacpica: Add makefile

2021-04-03 Thread Damien Zammit
--- Makefile | 1 + libacpica/Makefile | 189 + 2 files changed, 190 insertions(+) create mode 100644 libacpica/Makefile diff --git a/Makefile b/Makefile index 0e2ee1ec..fd8cef4d 100644 --- a/Makefile +++ b/Makefile @@ -32,6 +32,7 @@ lib-su

[hurd - ACPICA]: v2

2021-04-03 Thread Damien Zammit
I am trying to refactor the acpi server to use acpica as a library. I have written some new RPCs for the acpi server for enabling acpi, sleeping, and requesting irq for a pci device. The latter still needs work for LNK -> _CRS and _SRS methods. Currently, we only need to enable acpi mode when shu