Re: problems with daily images

2021-01-23 Thread Damien Zammit
Hi Samuel, On 24/1/21 12:32 pm, Samuel Thibault wrote: > Damien Zammit, le dim. 24 janv. 2021 12:26:35 +1100, a ecrit: >> I think we still need to pass -DPOSIX to vim CFLAGS for hurd, >> otherwise it will not call any flush function if you remove the #define. > > Ok, but AIUI it doesn't do any su

Re: problems with daily images

2021-01-23 Thread Damien Zammit
Hi, On 23/1/21 12:03 pm, Paul Dufresne wrote: > I have seen problems with daily images from: > https://people.debian.org/~sthibault/hurd-i386/installer/cdimage/ > > Was problems with vim, emacs, gdb... in previous days... I think but unsure > Idon't seems to see them now. > Had tried previous mo

Re: problems with daily images

2021-01-23 Thread Jessica Clarke
On 24 Jan 2021, at 01:52, Jessica Clarke wrote: > On 24 Jan 2021, at 01:27, Samuel Thibault wrote: >> Jessica Clarke, le dim. 24 janv. 2021 01:16:13 +, a ecrit: >>> maybe Hurd should also be nice. >> >> Right, we could hack ioctl into doing if (request == TIOCFLUSH && !arg) >> arg = &zero. >

Re: problems with daily images

2021-01-23 Thread Jessica Clarke
On 24 Jan 2021, at 01:27, Samuel Thibault wrote: > Jessica Clarke, le dim. 24 janv. 2021 01:16:13 +, a ecrit: >> maybe Hurd should also be nice. > > Right, we could hack ioctl into doing if (request == TIOCFLUSH && !arg) > arg = &zero. > > That still leaves us with applications that don't ev

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Damien Zammit, le dim. 24 janv. 2021 12:26:35 +1100, a ecrit: > On 24/1/21 12:18 pm, Samuel Thibault wrote: > > I'm starting to think that perhaps we should as well just comment the > > #define TIOCFLUSH from the headers, since there are so many bogus > > callers of the interface. > > I think we s

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Jessica Clarke, le dim. 24 janv. 2021 01:16:13 +, a ecrit: > maybe Hurd should also be nice. Right, we could hack ioctl into doing if (request == TIOCFLUSH && !arg) arg = &zero. That still leaves us with applications that don't even pass an argument, but I guess we can convince their maintain

Re: problems with daily images

2021-01-23 Thread Damien Zammit
On 24/1/21 12:18 pm, Samuel Thibault wrote: > I'm starting to think that perhaps we should as well just comment the > #define TIOCFLUSH from the headers, since there are so many bogus > callers of the interface. I think we still need to pass -DPOSIX to vim CFLAGS for hurd, otherwise it will not ca

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Jessica Clarke, le dim. 24 janv. 2021 00:59:23 +, a ecrit: > On 24 Jan 2021, at 00:41, Damien Zammit wrote: > >(void)ioctl(f, TIOCFLUSH, (char *) 0); > > It seems only QNX ends up setting POSIX for some inexplicable reason. > Since Hurd defines TIOCFLUSH, it ends up calling this line. But

Re: problems with daily images

2021-01-23 Thread Jessica Clarke
On 24 Jan 2021, at 00:59, Jessica Clarke wrote: > On 24 Jan 2021, at 00:41, Damien Zammit wrote: >> >> Hi, >> >> On 24/1/21 11:28 am, Samuel Thibault wrote: >>> Why so? We do support SSE*. >>> >>> (glibc 2.33 will even use them automatically for memcpy etc. thanks to >>> ifunc support recently

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Damien Zammit, le dim. 24 janv. 2021 11:41:23 +1100, a ecrit: > OK, I ran the failing test in GDB: Thanks! > #3 0x081cc30f in initmaster (f=4) at pty.c:212 Which line is this exactly, within this function? > initmaster(int f UNUSED) > { > #ifndef VMS > # ifdef POSIX > tcflush(f, TCIOFLUSH)

Re: problems with daily images

2021-01-23 Thread Jessica Clarke
On 24 Jan 2021, at 00:41, Damien Zammit wrote: > > Hi, > > On 24/1/21 11:28 am, Samuel Thibault wrote: >> Why so? We do support SSE*. >> >> (glibc 2.33 will even use them automatically for memcpy etc. thanks to >> ifunc support recently getting enabled) > > OK, I ran the failing test in GDB: >

Re: problems with daily images

2021-01-23 Thread Damien Zammit
Hi, On 24/1/21 11:41 am, Damien Zammit wrote: > OK, I ran the failing test in GDB: Forgot to paste the command I used: vim/src/vim-gtk3/testdir $ VIMRUNTIME=../../runtime gdb --args ../vim -f -u unix.vim -U NONE --noplugin --not-a-term -S runtest.vim test_arglist.vim --cmd 'au SwapExists * l

Re: problems with daily images

2021-01-23 Thread Damien Zammit
Hi, On 24/1/21 11:28 am, Samuel Thibault wrote: > Why so? We do support SSE*. > > (glibc 2.33 will even use them automatically for memcpy etc. thanks to > ifunc support recently getting enabled) OK, I ran the failing test in GDB: initmaster(int f UNUSED) { #ifndef VMS # ifdef POSIX tcflush(

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Damien Zammit, le dim. 24 janv. 2021 11:22:58 +1100, a ecrit: > On 24/1/21 3:32 am, Samuel Thibault wrote: > > Yes, but the real answer is that we should fix vim. > > I noticed that vim is building with -O2, shouldn't it also have these flags > for hurd-i386? > > -mno-sse -mno-mmx -mno-sse2 -mno

Re: problems with daily images

2021-01-23 Thread Damien Zammit
Hi, On 24/1/21 3:32 am, Samuel Thibault wrote: > Yes, but the real answer is that we should fix vim. I noticed that vim is building with -O2, shouldn't it also have these flags for hurd-i386? -mno-sse -mno-mmx -mno-sse2 -mno-3dnow I will try rebuilding the package with these flags and see if i

Re: [PATCH 2/2] pfinet: fix a missed 'return' keyword.

2021-01-23 Thread Samuel Thibault
Guy-Fleury Iteriteka, le dim. 24 janv. 2021 00:12:55 +0200, a ecrit: > * pfinet/ethernet.c(ethernet_close): Add 'return 0;' at the > end of function. Applied, thanks! > --- > pfinet/ethernet.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/pfinet/ethernet.c b/pfinet/ethernet.c > in

[PATCH 2/2] pfinet: fix a missed 'return' keyword.

2021-01-23 Thread Guy-Fleury Iteriteka
* pfinet/ethernet.c(ethernet_close): Add 'return 0;' at the end of function. --- pfinet/ethernet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pfinet/ethernet.c b/pfinet/ethernet.c index 1b3b5d0..5c69b54 100644 --- a/pfinet/ethernet.c +++ b/pfinet/ethernet.c @@ -263,6 +263,8 @@ etherne

Re: [PATCH 1/2] pfinet: fix missed include files.

2021-01-23 Thread Samuel Thibault
Guy-Fleury Iteriteka, le dim. 24 janv. 2021 00:12:54 +0200, a ecrit: > * pfinet/glue-include/linux/socket.h: include '' for 'memcpy' > and '' for 'abort'. Applied, thanks! > --- > pfinet/glue-include/linux/socket.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/pfi

[PATCH 1/2] pfinet: fix missed include files.

2021-01-23 Thread Guy-Fleury Iteriteka
* pfinet/glue-include/linux/socket.h: include '' for 'memcpy' and '' for 'abort'. --- pfinet/glue-include/linux/socket.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pfinet/glue-include/linux/socket.h b/pfinet/glue-include/linux/socket.h index a7475ea..87ddedc 100644 --

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Samuel Thibault, le sam. 23 janv. 2021 17:32:51 +0100, a ecrit: > More to the point: what pointed you to the daily builds? (I have now fixed some remaining references in the wiki, but there are possibly other pages you have been looking at, which still need fixing) Samuel

Re: problems with daily images

2021-01-23 Thread Samuel Thibault
Paul Dufresne, le sam. 23 janv. 2021 11:13:12 -0500, a ecrit: > I did found: > [1]https://buildd.debian.org/status/package.php?p=vim&suite=sid#problem-4 > which seems related to what you said about vim segfaulting during build. That is it, yes. > I care that the installation process fail on daily

Re: problems with daily images

2021-01-23 Thread Paul Dufresne
I have tried to refrain to respond fastly, trying to find what you are talking about. But frankly I think it will not change much my answer. I did found: https://buildd.debian.org/status/package.php?p=vim&suite=sid#problem-4 which seems related to what you said about vim segfaulting during bui