Re: [PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

2020-12-21 Thread Simon Marchi
On 2020-12-21 12:59 p.m., Samuel Thibault via Gdb-patches wrote: > gnu-nat.c was getting the inclusion of vm_param.h only by luck. We > need to explicitly include it to be sure to get the definitions of > VM_MIN/MAX_ADDRESS. > > gdb/ChangeLog: > > * gnu-nat.c: Include . > > diff --git

[PATCH] hurd: Fix getting VM_MIN/MAX_ADDRESS

2020-12-21 Thread Samuel Thibault
gnu-nat.c was getting the inclusion of vm_param.h only by luck. We need to explicitly include it to be sure to get the definitions of VM_MIN/MAX_ADDRESS. gdb/ChangeLog: * gnu-nat.c: Include . diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index 1693ce0c43..6f290be0d5 100644 --- a/gdb/gnu-nat

[PATCHv2] hurd: libgcc unwinding over signal trampolines with SIGINFO

2020-12-21 Thread Samuel Thibault
When the application sets SA_SIGINFO, the signal trampoline parameters are different to follow POSIX. libgcc/ * config/i386/gnu-unwind.h (x86_gnu_fallback_frame_state): Add the posix siginfo case to struct handler_args. Detect between legacy and siginfo from the second parameter, which is a small

Re: [PATCH] hurd: libgcc unwinding over signal trampolines with SIGINFO

2020-12-21 Thread Samuel Thibault
Jessica Clarke, le lun. 21 déc. 2020 14:21:39 +, a ecrit: > On 21 Dec 2020, at 14:09, Samuel Thibault wrote: > > @@ -75,29 +86,52 @@ x86_gnu_fallback_frame_state > > return _URC_END_OF_STACK; > > > > handler_args = context->cfa; > > - scp = handler_args->scp; > > - usp = scp->sc_uesp;

Re: [PATCH] hurd: libgcc unwinding over signal trampolines with SIGINFO

2020-12-21 Thread Jessica Clarke
On 21 Dec 2020, at 14:09, Samuel Thibault wrote: > @@ -75,29 +86,52 @@ x86_gnu_fallback_frame_state > return _URC_END_OF_STACK; > > handler_args = context->cfa; > - scp = handler_args->scp; > - usp = scp->sc_uesp; > + sigcode = handler_args->legacy.sigcode; > + if (sigcode < 4096) Do y

[PATCH] hurd: libgcc unwinding over signal trampolines with SIGINFO

2020-12-21 Thread Samuel Thibault
When the application sets SA_SIGINFO, the signal trampoline parameters are different to follow POSIX. libgcc/ * config/i386/gnu-unwind.h (x86_gnu_fallback_frame_state): Add the posix siginfo case to struct handler_args. Detect between legacy and siginfo from the second parameter, which is a small