Re: PCI arbiter crash on last qemu image

2020-08-22 Thread Joan Lledó
Hi, El 22/8/20 a les 15:10, Damien Zammit ha escrit: > Hi Joan, > > I found another probe() call in hurd_pci.c that should not be there. > (So I dropped a second incorrect patch). > Can you please confirm this final branch looks correct? > > http://git.zammit.org/libpciaccess.git/log/?h=rumpdisk

Re: PCI arbiter crash on last qemu image

2020-08-22 Thread Damien Zammit
Hi Joan, I found another probe() call in hurd_pci.c that should not be there. (So I dropped a second incorrect patch). Can you please confirm this final branch looks correct? http://git.zammit.org/libpciaccess.git/log/?h=rumpdisk-upstream Thanks, Damien

Re: PCI arbiter crash on last qemu image

2020-08-22 Thread Damien Zammit
On 22/8/20 8:38 pm, Joan Lledó wrote: > However, I think the problem here is the x86 backend, not the common > interface. If we take a look at all other backends we'll see that: > > 1.- Neither of them call its probe() from its create(). So it's the > client who must call pci_device_probe(), it's

Re: PCI arbiter crash on last qemu image

2020-08-22 Thread Joan Lledó
Hi, > I have removed my latest patch from my upstream merge request and replaced it > with a patch that fixes the problem: I took a look at your patch. > mappings[devp->num_mappings].flags = map_flags; > mappings[devp->num_mappings].memory = NULL; > > -if (dev->regions[region].memo