Re: gnumach: [PATCH] - irq as a mach device

2020-07-09 Thread Samuel Thibault
Hello, I committed the IRQ part, the compatibility part wasn't completely trivial, but it's now in at last :) We can now work on making netdde and rump move to the upstream interface. Samuel

Re: gnumach: [PATCH] - irq as a mach device

2020-07-09 Thread Samuel Thibault
Hello, I committed the vm_allocate_contiguous part. Of course there were a few missing bits: - phys_addr_t, as exposed to userland, *has* to be always the same size, otherwise the RPC will get bogus depending the kernel is compiled with PAE enabled or not. - It was put in mach.defs, but as the c

Re: gnumach: [PATCH] - irq as a mach device

2020-07-09 Thread Samuel Thibault
Damien Zammit, le jeu. 09 juil. 2020 21:14:59 +1000, a ecrit: > On 9/7/20 9:45 am, Samuel Thibault wrote: > >> + size = vm_page_round(size + palign); > > > >>alloc_size = (1 << (order + PAGE_SHIFT)); > >>npages = vm_page_atop(alloc_size); > > > > I don't think you need to add palign, tha

Re: gnumach: [PATCH] - irq as a mach device

2020-07-09 Thread Damien Zammit
On 9/7/20 9:45 am, Samuel Thibault wrote: > Thanks! It looks good, just a couple last things: > > - you don't need to introduce and call mach_cli(), splhigh already > disables interrupts, see the implementation in i386/i386/spl.S ACK > - Please keep intr.h's __INTR_H__ guard for consistency.