Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Damien Zammit, le lun. 30 mars 2020 10:16:29 +1100, a ecrit: > I don't know if I can do that, I committed an upstream branch, > then merged it into master and added patches. Ok. Ah, there is a upstream/0_20191130 tag, I can build the orig tarball from that. Samuel

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Damien Zammit
On 30/3/20 7:06 am, Samuel Thibault wrote: > Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: >> Then you'll need me to push latest rumpkernel tree so you can build rump libs > > Could you commit the upstream tarballs to the repo as well so I have the > correct version? You can do it b

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Hello, Damien Zammit, le dim. 29 mars 2020 23:19:28 +1100, a ecrit: > >> - put the files common to dde-based and rump-based libmachdev to > >> libmachdev/. I cleaned that quite heavily, to have something that actually looks like a library :) Along the way I renamed various things, basically to

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > Then you'll need me to push latest rumpkernel tree so you can build rump libs Could you commit the upstream tarballs to the repo as well so I have the correct version? You can do it by running this inside the debian repo: pristine-tar

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Damien Zammit, le dim. 29 mars 2020 23:19:28 +1100, a ecrit: > I created a ds_pre_server() hook in libmachdev and implemented it for > libmachdevdde, > and left an empty stub for libmachdevrump. I don't see why making it a hook: +void ds_pre_server(void) +{ + /* empty */ +} + +int main() +{ +

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Damien Zammit, le dim. 29 mars 2020 23:19:28 +1100, a ecrit: > On 29/3/20 4:16 pm, Damien Zammit wrote: > > Hurd TODO for Damien: > > = > > > > - Fix libstore patch > Done Applied, thanks! Samuel

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Damien Zammit
On 29/3/20 4:16 pm, Damien Zammit wrote: > Hurd TODO for Damien: > = > > - Fix libstore patch Done > - Remove useless debugging eg: Done > > - Remove most of this header: >>> +++ b/libmachdevrump/dev_hdr.h >> - put the files common to dde-based and rump-based libmachdev to

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Damien Zammit, le dim. 29 mars 2020 15:55:42 +1100, a ecrit: > I fixed rump instead. It now unmaps pci devices correctly and I tested > it without the above patch at all, it works. Ok, that's better. > > I don't really know why libpciaccess maintainers thought it should > > exclude mapping the s

Re: [PATCH] rumpkernel dependencies

2020-03-29 Thread Samuel Thibault
Damien Zammit, le dim. 29 mars 2020 16:01:30 +1100, a ecrit: > On 29/3/20 11:24 am, Samuel Thibault wrote: > > Damien Zammit, le sam. 28 mars 2020 16:50:41 +1100, a ecrit: > >> Apply these first to libpciaccess: > >> upstreaming/libpciaccess/99-fix-pciconf-calls > >> upstreaming/libpciaccess/99-reg