Re: [PATCH]: gnumach - simplify interrupt handling

2019-11-11 Thread Samuel Thibault
Samuel Thibault, le lun. 11 nov. 2019 19:06:21 +0100, a ecrit: > Justus Winter, le lun. 11 nov. 2019 19:03:46 +0100, a ecrit: > > I remember thinking about using a send-once right that when deallocated > > enables the interrupt again. This should be a) well optimized, and b) > > robust in the face

Re: [PATCH]: gnumach - simplify interrupt handling

2019-11-11 Thread Samuel Thibault
Justus Winter, le lun. 11 nov. 2019 19:03:46 +0100, a ecrit: > I remember thinking about using a send-once right that when deallocated > enables the interrupt again. This should be a) well optimized, and b) > robust in the face of misbehaving userland. I was thinking about something like that to

Re: [PATCH]: gnumach - simplify interrupt handling

2019-11-11 Thread Justus Winter
Samuel Thibault writes: > A simpler way for now would be to make deliver_intr and > device_intr_enable count how many "disables" we have for each irq. > Both device_intr_register and deliver_intr would increase it (and thus > disable the irq), and userland would have to call device_intr_enable >

Re: [PATCH]: gnumach - simplify interrupt handling

2019-11-11 Thread Samuel Thibault
Samuel Thibault, le lun. 11 nov. 2019 17:52:36 +0100, a ecrit: > That being said, now netdde with e1000 works only because linux_intr > calls disable_irq before queue_intr. If that is not done, we keep > getting interrupts. This really looks like an edge-vs-level trigger > issue which we need to cl

Re: [PATCH]: gnumach - simplify interrupt handling

2019-11-11 Thread Samuel Thibault
Damien Zammit, le lun. 11 nov. 2019 21:23:15 +1100, a ecrit: > On 11/11/19 3:08 am, Samuel Thibault wrote: > > Samuel Thibault, le dim. 10 nov. 2019 16:25:22 +0100, a ecrit: > >> Samuel Thibault, le dim. 10 nov. 2019 16:22:04 +0100, a ecrit: > >>> Ok, I have restored some of the mask/unmask_irq, so

Re: [PATCH]: gnumach - simplify interrupt handling

2019-11-11 Thread Damien Zammit
On 11/11/19 3:08 am, Samuel Thibault wrote: > Samuel Thibault, le dim. 10 nov. 2019 16:25:22 +0100, a ecrit: >> Samuel Thibault, le dim. 10 nov. 2019 16:22:04 +0100, a ecrit: >>> Ok, I have restored some of the mask/unmask_irq, so that curr_pic_mask >>> will still exist, but without the notion of s