[PATCH] hurd - ACPI tables netfs translator

2018-11-10 Thread Damien Zammit
Hello, This patch provides a translator for mounting x86 ACPI tables under a path as read-only files. I believe it is needed so that other things that depend on ACPI to find the base address such as Intel's IOMMU (DMAR table), memory mapped PCI space (MCFG table) etc, can be discovered in userspa

Re: [PATCH] gnumach - Restrict pci io cfg ports to one process

2018-11-10 Thread Damien Zammit
On 11/11/18 12:51, Samuel Thibault wrote: > Damien Zammit, le dim. 11 nov. 2018 12:43:07 +1100, a ecrit: >> +#define IS_IN_PROTECTED_RANGE(from, to) \ >> + ( ( ( from <= PCI_CFG1_START ) && ( to >= PCI_CFG1_END ) ) || \ > > That should be from <= END && to >= BEGIN, shouldn't it? Well, in my min

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Damien Zammit
On 11/11/18 13:05, Samuel Thibault wrote: > Do you know how your copyright assignment is going, so I can commit it? Haven't heard anything since I sent through my request. Damien

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Samuel Thibault
Hello, Thanks for the revised patch :) Do you know how your copyright assignment is going, so I can commit it? Samuel

Re: [PATCH] gnumach - Restrict pci io cfg ports to one process

2018-11-10 Thread Samuel Thibault
Damien Zammit, le dim. 11 nov. 2018 12:43:07 +1100, a ecrit: > +#define IS_IN_PROTECTED_RANGE(from, to) \ > + ( ( ( from <= PCI_CFG1_START ) && ( to >= PCI_CFG1_END ) ) || \ That should be from <= END && to >= BEGIN, shouldn't it? Samuel

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Damien Zammit
On 10/11/18 20:42, Samuel Thibault wrote: > Damien Zammit, le sam. 10 nov. 2018 18:58:35 +1100, a ecrit: >> +CPPFLAGS += -imacros $(srcdir)/config.h > > Why is this needed? I have now removed config.h and this line. > So it seems that libpciaccess doesn't provide an interface for this. > Please

Re: [PATCH] gnumach - Restrict pci io cfg ports to one process

2018-11-10 Thread Damien Zammit
On 10/11/18 20:50, Samuel Thibault wrote: > The data register port is 0xCFC + (reg & 3); so it could be as much as > 0xCFF. > > The x86 conf2 method also uses 0xC000 | dev << 8 | reg; so we need to > also protect 0xc000 - 0xcfff. See attached patch with corrections. Thanks, Damien >From b79f52db

Re: Wiki Edits: ascii art on the anatomy of a hurd system page

2018-11-10 Thread Samuel Thibault
Also, please base your future patches on the head of the git, not on your previous patches which I haven't applied (and don't plan to apply) Samuel

Re: Wiki Edits: ascii art on the anatomy of a hurd system page

2018-11-10 Thread Samuel Thibault
Joshua Branson, le sam. 10 nov. 2018 10:32:15 -0500, a ecrit: > Samuel Thibault writes: > > > Joshua Branson, le ven. 09 nov. 2018 11:59:31 -0500, a ecrit: > >> > It's correct, but could be improved: I'd say rather take the example of > >> > glibc's send(), which is an RPC handled by pfinet, whic

Re: Wiki Edits: ascii art on the anatomy of a hurd system page

2018-11-10 Thread Joshua Branson
Samuel Thibault writes: > Joshua Branson, le ven. 09 nov. 2018 11:59:31 -0500, a ecrit: >> > It's correct, but could be improved: I'd say rather take the example of >> > glibc's send(), which is an RPC handled by pfinet, which uses a >> > device_write RPC to actually emit an Ethernet frame, which

Re: Wiki Edits: Cleaning up anatomy, deleting a comment, adding an image to microkernel page

2018-11-10 Thread Joshua Branson
Samuel Thibault writes: > Hello, > > I applied it except. > >> I added an image to the microkernel page. > > It could be much better by introducing the glibc layer and writing > "POSIX call" and "RPC calls". On monolithic systems, the application > calls a glibc function which just makes a system

Re: Wiki Edits: ascii art on the anatomy of a hurd system page

2018-11-10 Thread Joshua Branson
Samuel Thibault writes: > Joshua Branson, le ven. 09 nov. 2018 11:59:31 -0500, a ecrit: >> > It's correct, but could be improved: I'd say rather take the example of >> > glibc's send(), which is an RPC handled by pfinet, which uses a >> > device_write RPC to actually emit an Ethernet frame, which

Re: Wiki Edits: ascii art on the anatomy of a hurd system page

2018-11-10 Thread Joshua Branson
Samuel Thibault writes: > Joshua Branson, le ven. 09 nov. 2018 11:59:31 -0500, a ecrit: >> > It's correct, but could be improved: I'd say rather take the example of >> > glibc's send(), which is an RPC handled by pfinet, which uses a >> > device_write RPC to actually emit an Ethernet frame, which

Re: [PATCH] gnumach - Restrict pci io cfg ports to one process

2018-11-10 Thread Samuel Thibault
Again, thanks :) Damien Zammit, le sam. 10 nov. 2018 19:17:32 +1100, a ecrit: > @@ -185,6 +191,13 @@ i386_io_perm_create (const ipc_port_t master_port, > io_port_t from, io_port_t to, >if (from > to) > return KERN_INVALID_ARGUMENT; > > + if (from <= PCI_CFG1_ADDRESS_REG && to >= PCI_C

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Samuel Thibault
Hello, Thanks for this :) Damien Zammit, le sam. 10 nov. 2018 18:58:35 +1100, a ecrit: > @@ -35,6 +35,8 @@ include ../Makeconf > > CFLAGS += -I$(PORTDIR)/include > > +CPPFLAGS += -imacros $(srcdir)/config.h Why is this needed? (that's the reason why you have to add a config.h file, but its

[PATCH] gnumach - Restrict pci io cfg ports to one process

2018-11-10 Thread Damien Zammit
Hi all, This patch for gnumach restricts the number of processes that can simultaneously access pci io cfg range of ports down to 1 as per discussion: https://lists.x.org/archives/xorg-devel/2018-November/057691.html Please review attached, thanks, Damien >From 8f5525e8d46b5cf47d7eaaeb92cdc2474

[PATCH] - hurd pci-arbiter: remove embedded pciaccess code

2018-11-10 Thread Damien Zammit
Hi all, This patch (see attached) removes all embedded pciaccess code from the arbiter, and adds config.h which is currently missing from master. NB: I have another patch for libpciaccess to add the hurd method and add Joan's tweaks to the raw x86 access method, but is not strictly essential to u