Re: [PATCH] hurd: -Werror

2015-02-07 Thread Samuel Thibault
Roland McGrath, le Sat 07 Feb 2015 18:20:31 -0800, a écrit : > Are you using --disable-werror for some reason? Yes: we have a lot of warnings related with mig: /usr/src/glibc/build/mach/RPC_default_pager_objects.c: In function '__default_pager_objects': /usr/src/glibc/build/mach/RPC_default_page

Re: [PATCH] hurd: add TLS support

2015-02-07 Thread Roland McGrath
> --- a/csu/libc-start.c > +++ b/csu/libc-start.c > @@ -189,10 +189,12 @@ LIBC_START_MAIN (int (*main) (int, char **, char ** > MAIN_AUXVEC_DECL), >/* Perform IREL{,A} relocations. */ >apply_irel (); > > +#ifndef __GNU__ >/* Initialize the thread library at least a bit since the lib

Re: [PATCH] hurd: Fix F_*LK* fcntl with __USE_FILE_OFFSET64

2015-02-07 Thread Samuel Thibault
Roland McGrath, le Sat 07 Feb 2015 18:20:31 -0800, a écrit : > > +# define F_GETLK 7 /* Get record locking info. */ > > +# define F_SETLK 8 /* Set record locking info > > (non-blocking). */ > > +# define F_SETLKW9 /* Set record locking info (blocki

Re: [PATCH] hurd: take __USE_EXTERN_INLINES into account

2015-02-07 Thread Samuel Thibault
Roland McGrath, le Sat 07 Feb 2015 18:15:14 -0800, a écrit : > I don't have any problem with it on principle or anything, but could you > say exactly what this is fixing in practical terms? I don't remember an exact issue, but at least it provides better debugging support by not inlining definitio

Re: [PATCH] hurd: Fix F_*LK* fcntl with __USE_FILE_OFFSET64

2015-02-07 Thread Roland McGrath
> +# define F_GETLK 7 /* Get record locking info. */ > +# define F_SETLK 8 /* Set record locking info > (non-blocking). */ > +# define F_SETLKW9 /* Set record locking info (blocking). > */ > +#endif > +#define F_GETLK64 10 /

Re: [PATCH] hurd: take __USE_EXTERN_INLINES into account

2015-02-07 Thread Roland McGrath
I don't have any problem with it on principle or anything, but could you say exactly what this is fixing in practical terms? > +#if defined __USE_EXTERN_INLINES && defined _LIBC && !defined NOT_IN_libc NOT_IN_libc is obsolete. It's now spelled !IS_IN (libc). Please confirm that you've tested th

Re: [PATCH] Fix connect/sendto/sendmsg into making sure to ignore bytes beyond sockaddr length

2015-02-07 Thread Roland McGrath
> Thanks Tanaka Akira for the report. General glibc policy is that if a bug was user-visible (i.e. observable in a user program that was not itself using undefined behavior, etc.) then there should be a bugzilla item filed for it. That BZ# should then be in the ChangeLog entry. > --- /dev/null >

Re: [PATCH hurd] startup: add more error handling

2015-02-07 Thread Samuel Thibault
Justus Winter, le Sun 08 Feb 2015 02:35:11 +0100, a écrit : > * startup/startup.c (launch_core_servers): Add more error handling. Ack! > --- > startup/startup.c | 63 > --- > 1 file changed, 41 insertions(+), 22 deletions(-) > > diff --git a/

[PATCH hurd] startup: add more error handling

2015-02-07 Thread Justus Winter
* startup/startup.c (launch_core_servers): Add more error handling. --- startup/startup.c | 63 --- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/startup/startup.c b/startup/startup.c index e01d2a8..da78b13 100644 --- a/startup/

Re: [PATCH] hurd: add TLS support

2015-02-07 Thread Samuel Thibault
Note: we also have the support for TLS-based per-thread glibc variables, I will submit that later. Samuel

[PATCH] hurd: add TLS support

2015-02-07 Thread Samuel Thibault
2009-07-30 Samuel Thibault Add TLS support: __mach_setup_tls allocates and sets architecture state for the TLS area. i386 fork needs to propagate the segment kernel definitions. * sysdeps/mach/hurd/bits/libc-lock.h [_LIBC - 0]: Include * sysdeps/mach/h

[PATCH] hurd: Allow unknown root directory

2015-02-07 Thread Samuel Thibault
To be efficient, the remap translator simply returns ports from the underlying filesystem, and thus the root directory found through browsing '..' is the underlying root, not the remap root. This should not be a reason for getcwd to fail. * sysdeps/mach/hurd/getcwd.c (_hurd_canonicalize_directory_

[PATCH] hurd: Fix F_*LK* fcntl with __USE_FILE_OFFSET64

2015-02-07 Thread Samuel Thibault
struct flock64 uses 64bit values. This introduces other values for F_GETLK, F_SETLK, F_SETLKW to distinguish between both. * sysdeps/mach/hurd/bits/fcntl.h (F_GETLK64, F_SETLK64, F_SETLKW64): New macros [__USE_FILE_OFFSET64] (F_GETLK, F_SETLK, F_SETLKW): Define to F_GETLK64, F_SETLK64, F_SETLKW64

[PATCH] hurd: take __USE_EXTERN_INLINES into account

2015-02-07 Thread Samuel Thibault
* hurd/hurd.h (__hurd_fail): Always declare function, and provide inline version only if __USE_EXTERN_INLINES is defined. * hurd/hurd/fd.h (_hurd_fd_get, _hurd_fd_error_signal, _hurd_fd_error, __hurd_dfail, __hurd_sockfail): Likewise. * mach/lock-intern.h (__spin_lock_init, __spin_lock, __mutex_loc

[PATCH] Fix connect/sendto/sendmsg into making sure to ignore bytes beyond sockaddr length

2015-02-07 Thread Samuel Thibault
2014-03-01 Samuel Thibault Thanks Tanaka Akira for the report. * hurd/hurdsocket.h: New file, defines _hurd_sun_path_dupa which duplicates ADDR->sun_path with sockaddr LEN limitation. * sysdeps/mach/hurd/connect.c: Include (__connect): Give result of _hurd_sun_