Re: [PATCH hurd-dde] libmachdev: avoid malloc overhead when sending package

Justus Winter, le Wed 26 Nov 2014 20:21:57 +0100, a écrit : > * libmachdev/net.c (netif_rx_handle): Allocate message buffer on the > stack. Ack, but rather turn -> into . etc. than defining a pointer just for the sake of not modifying the source code :) Samuel

[PATCH hurd-dde] libmachdev: avoid malloc overhead when sending package

* libmachdev/net.c (netif_rx_handle): Allocate message buffer on the stack. --- libmachdev/net.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libmachdev/net.c b/libmachdev/net.c index e04fa80..99368d7 100644 --- a/libmachdev/net.c +++ b/libmachdev/net.c @@ -223,7 +223

Re: [PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending package

On Wed, Nov 26, 2014 at 06:49:40PM +0100, Samuel Thibault wrote: > Justus Winter, le Wed 26 Nov 2014 15:22:34 +0100, a écrit : > > * libmachdev/net.c (netif_rx_handle): Allocate message buffer on the > > stack. > > Mmm, why not simply making it a struct net_rcv_msg variable? Yes, please avoid all

Re: [PATCH hurd-dde 2/7] Remove obsolete device server stubs

Justus Winter, le Wed 26 Nov 2014 15:22:31 +0100, a écrit : > Remove server implementations for the obsolete RPCs > `xxx_device_set_status', `xxx_device_get_status', and > `xxx_device_set_filter'. Ack. > * devnode/devnode.c: Remove obsolete device server stubs. > * eth-filter.multi-thread/filter.

Re: [PATCH hurd-dde 7/7] libmachdev: drop static libmachdev.so hack

Justus Winter, le Wed 26 Nov 2014 15:22:36 +0100, a écrit : > Previously, netdde was built against `libmachdev.a' to avoid some > uninvestigated linking problems. netdde using a statically linked > libmachdev lead to problems in the past. As the linking problems only > affect functions required f

Re: [PATCH hurd-dde 6/7] libmachdev: fix size of `net_rcv_msg' message

Justus Winter, le Wed 26 Nov 2014 15:22:35 +0100, a écrit : > Account for the `struct packet_header' that is prepended to the > network packet in the calculation of the `net_rcv_msg' message. This > complements e363aa56. Ack. > * libmachdev/net.c (netif_rx_handle): Fix size of message. > --- >

Re: [PATCH hurd-dde 1/7] Drop superfluous files

Justus Winter, le Wed 26 Nov 2014 15:22:30 +0100, a écrit : > * eth-multiplexer/device.h: Drop MIG-generated file. > * libmachdev/device.defs: Drop superfluous file. Ack.

Re: [PATCH hurd-dde 4/7] libmachdev: drop debugging printf

Justus Winter, le Wed 26 Nov 2014 15:22:33 +0100, a écrit : > * libmachdev/net.c (netif_rx_handle): Avoid calling `printf' for every > incoming handle. Ack. > --- > libmachdev/net.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/libmachdev/net.c b/libmachdev/net.c > index 53edcd0.

Re: [PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending package

Justus Winter, le Wed 26 Nov 2014 15:22:34 +0100, a écrit : > * libmachdev/net.c (netif_rx_handle): Allocate message buffer on the > stack. Mmm, why not simply making it a struct net_rcv_msg variable? > --- > libmachdev/net.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff

Re: [PATCH hurd-dde 3/7] libmachdev: drop unused function

Justus Winter, le Wed 26 Nov 2014 15:22:32 +0100, a écrit : > * libmachdev/ds_routines.c (mach_convert_device_to_port): Drop function. Ack. > --- > libmachdev/ds_routines.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/libmachdev/ds_routines.c b/libmachdev/ds_routines.c >

Re: dns issue

Hi Adam :) Quoting Adam Richards (2014-11-26 14:30:05) > I have been lurking on the IRC archive for sometime > and running your sources on VirtualBox on a Mac. You are a brave soul then, remember to keep some snapshots around if you are using my packages ;) > One of the updates about 3-4 (?) mon

dns issue

Hi Justus, I have been lurking on the IRC archive for sometime and running your sources on VirtualBox on a Mac. One of the updates about 3-4 (?) months back started affecting dns lookup but only if I reboot. Without rebooting it continues to work. If I reboot ping works but dns works strangely:

[PATCH hurd-dde 3/7] libmachdev: drop unused function

* libmachdev/ds_routines.c (mach_convert_device_to_port): Drop function. --- libmachdev/ds_routines.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/libmachdev/ds_routines.c b/libmachdev/ds_routines.c index 5287bf4..e9fbe94 100644 --- a/libmachdev/ds_routines.c +++ b/libmachdev/ds_

[PATCH hurd-dde 4/7] libmachdev: drop debugging printf

* libmachdev/net.c (netif_rx_handle): Avoid calling `printf' for every incoming handle. --- libmachdev/net.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libmachdev/net.c b/libmachdev/net.c index 53edcd0..5a5cd5d 100644 --- a/libmachdev/net.c +++ b/libmachdev/net.c @@ -104,8 +104,6 @@ s

[PATCH hurd-dde 6/7] libmachdev: fix size of `net_rcv_msg' message

Account for the `struct packet_header' that is prepended to the network packet in the calculation of the `net_rcv_msg' message. This complements e363aa56. * libmachdev/net.c (netif_rx_handle): Fix size of message. --- libmachdev/net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libmachde

[PATCH hurd-dde 7/7] libmachdev: drop static libmachdev.so hack

Previously, netdde was built against `libmachdev.a' to avoid some uninvestigated linking problems. netdde using a statically linked libmachdev lead to problems in the past. As the linking problems only affect functions required for block devices, which we do not use at this point, we can simply s

[PATCH hurd-dde 2/7] Remove obsolete device server stubs

Remove server implementations for the obsolete RPCs `xxx_device_set_status', `xxx_device_get_status', and `xxx_device_set_filter'. * devnode/devnode.c: Remove obsolete device server stubs. * eth-filter.multi-thread/filter.c: Likewise. * eth-filter/filter.c: Likewise. * eth-multiplexer/device_impl.

[PATCH hurd-dde 5/7] libmachdev: avoid malloc overhead when sending package

* libmachdev/net.c (netif_rx_handle): Allocate message buffer on the stack. --- libmachdev/net.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libmachdev/net.c b/libmachdev/net.c index 5a5cd5d..7ddf95d 100644 --- a/libmachdev/net.c +++ b/libmachdev/net.c @@ -232,9 +232,7

[PATCH hurd-dde 1/7] Drop superfluous files

* eth-multiplexer/device.h: Drop MIG-generated file. * libmachdev/device.defs: Drop superfluous file. --- eth-multiplexer/device.h | 336 --- libmachdev/device.defs | 175 2 files changed, 511 deletions(-) delete mode 100644 e