Re: [PATCH hurd 9/9] boot: improve the demuxer

2014-11-07 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:32:02 +0100, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. > > * boot/boot.c (mig

Re: [PATCH hurd 6/9] boot: drop obsolete device procedures

2014-11-07 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:31:59 +0100, a écrit : > * boot/boot.c (ds_xxx_device_set_status): Remove function. > (ds_xxx_device_get_status): Likewise. > (ds_xxx_device_set_filter): Likewise. Ack. > --- > boot/boot.c | 34 -- > 1 file changed, 34 deletion

Re: [PATCH hurd 4/9] boot: drop bootstrap compat code

2014-11-07 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 17:31:57 +0100, a écrit : > GNU Mach never sent old-style bootstrap messages. Drop the unused > compatibility code. > > * boot/boot.c (request_server): Drop unused code. > (bootstrap_compat): Drop unused function. Ack. > --- > boot/boot.c | 78 > -

[PATCH hurd 6/9] boot: drop obsolete device procedures

2014-11-07 Thread Justus Winter
* boot/boot.c (ds_xxx_device_set_status): Remove function. (ds_xxx_device_get_status): Likewise. (ds_xxx_device_set_filter): Likewise. --- boot/boot.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/boot/boot.c b/boot/boot.c index 250018e..a655107 100644 ---

[PATCH hurd 9/9] boot: improve the demuxer

2014-11-07 Thread Justus Winter
Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. * boot/boot.c (mig_reply_setup): Provide local version. (request_server): Rename to `boot_

[PATCH hurd 8/9] boot: implement pseudo-time device

2014-11-07 Thread Justus Winter
* boot/boot.c (pseudo_time): New variable. (main): Allocate port `pseudo_time'. (ds_device_open): Give out `pseudo_time'. (ds_device_map): Emulate Mach-style `Mapped Time'. --- boot/boot.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/b

[PATCH hurd 7/9] boot: support ds_device_get_status with flavor DEV_GET_RECORDS

2014-11-07 Thread Justus Winter
* boot/boot.c (ds_device_get_status): Support flavor DEV_GET_RECORDS. --- boot/boot.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/boot/boot.c b/boot/boot.c index a655107..d35ce50 100644 --- a/boot/boot.c +++ b/boot/boot.c @@ -1150,18 +115

[PATCH hurd 3/9] startup: also open `console' for reading

2014-11-07 Thread Justus Winter
* startup/startup.c (main): Also open `console' for reading. --- startup/startup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/startup/startup.c b/startup/startup.c index ff58270..e177075 100644 --- a/startup/startup.c +++ b/startup/startup.c @@ -557,7 +557,7 @@ main (int a

[PATCH hurd 5/9] boot: remove unused function `boot_script_read_file'

2014-11-07 Thread Justus Winter
The unused function `boot_script_read_file' requires access to the default pager, which is privileged. * boot/boot.c (defpager): Remove now unused variable. (boot_script_read_file): Remove unused function. (main): Do not acquire port to the default pager. * boot/boot_script.h (boot_script_read_fil

[PATCH hurd 2/9] proc: gracefully handle failure to increase priority

2014-11-07 Thread Justus Winter
* proc/main.c (increase_priority): New function. (main): Move code increasing the proc servers priority to a new function and handle errors gracefully. --- proc/main.c | 44 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/proc/main.c b/p

[PATCH hurd 4/9] boot: drop bootstrap compat code

2014-11-07 Thread Justus Winter
GNU Mach never sent old-style bootstrap messages. Drop the unused compatibility code. * boot/boot.c (request_server): Drop unused code. (bootstrap_compat): Drop unused function. --- boot/boot.c | 78 - 1 file changed, 78 deletions(-) d

[PATCH hurd 1/9] Makeconf: handle the gnumach protocol

2014-11-07 Thread Justus Winter
* Makeconf (mach_defs_names): Add `gnumach'. --- Makeconf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makeconf b/Makeconf index 32eec13..f0d3fe3 100644 --- a/Makeconf +++ b/Makeconf @@ -575,7 +575,9 @@ vpath %.defs $(top_srcdir)/hurd # These we want to find in the libc

Re: [PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Samuel Thibault
Richard Braun, le Fri 07 Nov 2014 16:53:31 +0100, a écrit : > On Fri, Nov 07, 2014 at 03:45:11PM +0100, Samuel Thibault wrote: > > Justus Winter, le Fri 07 Nov 2014 15:41:43 +0100, a écrit : > > > So one only gets default implementations if one defines an appropriate > > > MIG_EOPNOTSUPP. > > > >

Re: [PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Richard Braun
On Fri, Nov 07, 2014 at 03:45:11PM +0100, Samuel Thibault wrote: > Justus Winter, le Fri 07 Nov 2014 15:41:43 +0100, a écrit : > > So one only gets default implementations if one defines an appropriate > > MIG_EOPNOTSUPP. > > Ah, I missed that part. It sounds good to me then. Other opinions? It

Re: [PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Justus Winter
Quoting Justus Winter (2014-11-07 15:41:43) > The reason why I want it is: > > % git grep EOPNOTSUPP|wc --lines > 1071 Better: % spatch --smpl-spacing --sp-file refactor/eopnotsupp.cocci --dir . | grep EOPNOTSUPP | wc --lines 269 So 269 functions matching the following ad-hoc coccinelle patch:

Re: [PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 15:41:43 +0100, a écrit : > So one only gets default implementations if one defines an appropriate > MIG_EOPNOTSUPP. Ah, I missed that part. It sounds good to me then. Other opinions? Samuel

Re: [PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Justus Winter
Quoting Samuel Thibault (2014-11-07 15:07:12) > Justus Winter, le Fri 07 Nov 2014 15:04:17 +0100, a écrit : > > By providing default implementations, servers can provide partial > > implementations of protocols without having to stub out functions. > > I'm not sure whether we want that. When some

Re: [PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Samuel Thibault
Justus Winter, le Fri 07 Nov 2014 15:04:17 +0100, a écrit : > By providing default implementations, servers can provide partial > implementations of protocols without having to stub out functions. I'm not sure whether we want that. When somebody has added something to a protocol, in my own server

[PATCH mig] Provide default implementations for server functions

2014-11-07 Thread Justus Winter
By providing default implementations, servers can provide partial implementations of protocols without having to stub out functions. * server.c (WriteDefaultRoutine): New function. (WriteRoutine): Call WriteDefaultRoutine. --- server.c | 24 1 file changed, 24 insertions(