Re: [PATCH 2/8] procfs: do not hard-code the default argument values

2014-10-05 Thread Samuel Thibault
Justus Winter, le Fri 05 Sep 2014 10:42:56 +0200, a écrit : > * procfs/main.c (common_options): If possible, do not hard-code the > default values. Ack. > --- > procfs/main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/procfs/main.c b/procfs/main.c > index f30

Re: [PATCH v2] utils/mount: add mount options to create firmlinks.

2014-10-05 Thread Samuel Thibault
Gabriele Giacone, le Tue 27 May 2014 22:20:29 +0200, a écrit : > * utils/mount.c (parse_opt): Add -B/--bind/--firmlink/-o bind mount > options. (do_mount): Do not pass bind mount option to settrans, set > firmlink fstype. (main): Likewise. Applied, thanks! > --- > utils/mount.c | 39 ++

Re: [PATCH 2/2] libports: lock-less reference counting for port_info objects

2014-10-05 Thread Samuel Thibault
Ack, thanks! Justus Winter, le Fri 05 Sep 2014 17:57:22 +0200, a écrit : > * libports/ports.h (struct port_info): Use the new type. > * libports/lookup-port.c: No need to lock _ports_lock anymore. > * libports/bucket-iterate.c: Likewise. > * libports/complete-deallocate.c: Check if someone reacqu

[PATCH] trans/mtab: avoid firmlink loops

2014-10-05 Thread Justus Winter
* trans/mtab.c (struct mtab): Add a hash table to keep track of seen ports. (mtab_mark_as_seen): New function that records the identity port of a given node in the hash table and reports whether it has been there before. (mtab_populate): Use the new function to avoid running in circles. (main, open

Re: mtab and firmlink loop

2014-10-05 Thread Justus Winter
Hi Samuel, Quoting Justus Winter (2014-10-02 12:57:52) > Quoting Samuel Thibault (2014-10-02 01:58:11) > > We're having issues with schroot and mtab on exodar. Looking a bit at > > rpctrace, one can see things like this: > > > > /home/srv/chroot/schroot-unpack/youpi/home/srv/chroot/schroot-unpack