Re: GDB testsuite: »Memory at address 0 is possibly executable«

2014-09-12 Thread Justus Winter
Quoting Samuel Thibault (2014-09-13 01:39:05) > So it seems we need what is not actually documented, i.e. a vm_map > with anywhere=1, but which takes into account the suggested address. > I'm fine with officially supporting that, we just need to fix the > documentation, I'm sorry, I'm lost. What

Re: GDB testsuite: »Memory at address 0 is possibly executable«

2014-09-12 Thread Samuel Thibault
(Just to be clear: I don't think the fix proposed by Justus initially is correct: it was essentially making applications with random addresses actually get to have their map done starting from address 0, but we really ought to rather fix their randomness directly) Samuel

Re: GDB testsuite: »Memory at address 0 is possibly executable«

2014-09-12 Thread Samuel Thibault
Mmm. So it seems we need what is not actually documented, i.e. a vm_map with anywhere=1, but which takes into account the suggested address. I'm fine with officially supporting that, we just need to fix the documentation, and fix all places which weren't aware of this behavior (there are very few)

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Sergio Durigan Junior
On Friday, September 12 2014, Samuel Thibault wrote: > What may help in the process would be to have a script which checks for > style. The Linux kernel's checkpatch.pl is a very good approach, since > one can get to check one's own style quite thoroughly before submitting. This has been discusse

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Samuel Thibault
Joel Brobecker, le Fri 12 Sep 2014 13:01:41 -0700, a écrit : > > > Many thanks for persisting with this patch. > > > > I have to say I'm almost about to give up with submitting it. > > I would be very interested in hearing your honest feedback on this. > I know it took a long time, and we're not

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Joel Brobecker
> > Many thanks for persisting with this patch. > > I have to say I'm almost about to give up with submitting it. I would be very interested in hearing your honest feedback on this. I know it took a long time, and we're not always very responsive, but we try our best. If we could hear what made y

Re: [PATCHv4,Hurd] Add hardware watch support

2014-09-12 Thread Sergio Durigan Junior
On Friday, September 12 2014, Joel Brobecker wrote: > This is now OK. I double-checked that Samuel does have a copyright > assignment on file, so Thomas is good to go for pushing the patch in > if he approves as well. If Sergio has any further comment on the patch, > we can address them as follow

Re: [PATCHv4,Hurd] Add hardware watch support

2014-09-12 Thread Joel Brobecker
Hello Samuel, On Fri, Sep 12, 2014 at 08:29:11PM +0200, Samuel Thibault wrote: > 2014-09-06 Samuel Thibault > > Add hardware watch support to gnu-i386 platform. > > This allows to get the "watch" command keep native code execution. > > * gdb/gdb/gnu-nat.c (inf_threads): N

Re: GDB testsuite: »Memory at address 0 is possibly executable«

2014-09-12 Thread Justus Winter
Hi :) Quoting Thomas Schwinge (2014-09-11 16:23:04) > $ ldd /bin/true > libc.so.0.3 => /lib/i386-gnu/libc.so.0.3 (0x0103a000) > /lib/ld.so => /lib/ld.so.1 (0x) > libmachuser.so.1 => /lib/i386-gnu/libmachuser.so.1 (0x011fa000) > libhurduse

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Sergio Durigan Junior
On Friday, September 12 2014, Samuel Thibault wrote: > Well, hardware watchpoints are fully documented in info. Yes, but I am not talking about writing documentation for GDB, I am talking about writing a commit message :-). >> Is it possible to submit a testcase for this as well? WDYT? > > AIUI

Re: SysV shutdown hanging

2014-09-12 Thread Justus Winter
Hi Thomas :) Quoting Thomas Schwinge (2014-09-12 09:16:32) > In my QEMU Debian GNU/Hurd instance, I do some stuff (GDB testsuite, for > example), and then issue a »sudo shutdown -r now«. This doesn't > complete, but hangs like this: > > PID UID PPID PGrp Sess TH Vmem RSS %CPU Us

[PATCHv4,Hurd] Add hardware watch support

2014-09-12 Thread Samuel Thibault
2014-09-06 Samuel Thibault Add hardware watch support to gnu-i386 platform. This allows to get the "watch" command keep native code execution. * gdb/gdb/gnu-nat.c (inf_threads): New function. * gdb/gdb/gnu-nat.h (inf_threads_ftype): New type. (inf_threa

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Samuel Thibault
Thomas Schwinge, le Fri 12 Sep 2014 19:56:13 +0200, a écrit : > Unless you have push access to sourceware (do you?), I don't. Samuel

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Samuel Thibault
Joel Brobecker, le Fri 12 Sep 2014 09:51:49 -0700, a écrit : > You forgot the comment I made about having the function documented > at only one location, and the contents of that documentat. I didn't forgot, but apparently I completely mangled my patch, sorry about that. Samuel

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Samuel Thibault
Sergio Durigan Junior, le Wed 10 Sep 2014 19:22:56 -0400, a écrit : > Thanks for the patch, Samuel. What do you think of writing a message > explaining a bit more of this feature, for the sake of putting it in the > commit message? Just thinking aloud here... Well, hardware watchpoints are fully

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Samuel Thibault
Thomas Schwinge, le Fri 12 Sep 2014 19:56:13 +0200, a écrit : > Unless you have push access to sourceware (do you?), I'll be happy to > push this for you once the pending review comments have been addressed. > I have just to contribute a small patch to add on top of yours (merge it > in) to make it

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Thomas Schwinge
Hi Samuel! Many thanks for persisting with this patch. The GDB testsuite shows a pretty good improvement! I'll try to assess the remaining issues, but From a functional point of view that patch is much of an improvement already. Unless you have push access to sourceware (do you?), I'll be happy

Re: [PATCHv3,Hurd] Add hardware watch support

2014-09-12 Thread Joel Brobecker
> 2014-09-06 Samuel Thibault > > Add hardware watch support to gnu-i386 platform. > > * gdb/gdb/gnu-nat.c (inf_threads): New function. > * gdb/gdb/gnu-nat.h (inf_threads_ftype): New type. > (inf_threads): New declaration. > * gdb/gdb/i386gnu-nat.c: Include "x86-na

SysV shutdown hanging

2014-09-12 Thread Thomas Schwinge
Hi! In my QEMU Debian GNU/Hurd instance, I do some stuff (GDB testsuite, for example), and then issue a »sudo shutdown -r now«. This doesn't complete, but hangs like this: PID UID PPID PGrp Sess TH Vmem RSS %CPU User System Args [...] 283860 1 28386 28386 2 1