Re: [PATCH 3/3] hurd: fix semantic of file_get_children

2014-08-31 Thread Samuel Thibault
Gabriele, could you check whether that fixes some of your concerns with pbuilder & sbuild? Samuel

A new HURD release?

2014-08-31 Thread Omar Radwan
With all the new things that are happening with Guix and dmd, to finish GNU, might there be a possiblity that the HURD have new release marking it stable? And actually fill in the spot of the GNU kernel? I think you guys should actually release 1.0, becuase it's pretty stable, I've tried the Debia

[PATCH,Hurd] Fix F_*LK* fcntl with __USE_FILE_OFFSET64

2014-08-31 Thread Samuel Thibault
2014-08-31 Samuel Thibault struct flock64 uses 64bit values. This introduces other values for F_GETLK, F_SETLK, F_SETLKW to distinguish between both. * sysdeps/mach/hurd/bits/fcntl.h (F_GETLK64, F_SETLK64, F_SETLKW64): New macros [__USE_FILE_OFFSET64] (

Re: [PATCH] include: detect use-after-free errors using the reference counts

2014-08-31 Thread Samuel Thibault
Ack. Justus Winter, le Sun 31 Aug 2014 19:59:48 +0200, a écrit : > * include/refcount.h (refcount_init): There must be at least one > reference at initialization time. > (refcounts_init): Likewise. > (refcount_unsafe_ref): New function retaining the previous > functionality of refcount_ref. It is

[PATCH] include: detect use-after-free errors using the reference counts

2014-08-31 Thread Justus Winter
* include/refcount.h (refcount_init): There must be at least one reference at initialization time. (refcounts_init): Likewise. (refcount_unsafe_ref): New function retaining the previous functionality of refcount_ref. It is occasionally useful to raise the reference count again after it dropped to

[PATCH,boehm-gc] Use mmap instead of brk on kfreebsd & hurd too

2014-08-31 Thread Samuel Thibault
Hello, Please use mmap instead of brk on kfreebsd and hurd too. Also, using anonymous memory is faster on the Hurd. Thanks, Samuel 2014-08-31 Samuel Thibault * configure.host: Set gc_use_mmap on *-kfreebsd-gnu* and *-gnu*. * include/private/gcconfig.h [HURD && USE_MMAP]: Defi

Re: [PATCH 2/3] libihash: fix comparison between signed and unsigned integer

2014-08-31 Thread Justus Winter
Quoting Samuel Thibault (2014-08-31 16:31:04) > Justus Winter, le Sun 31 Aug 2014 16:25:00 +0200, a écrit : > > * libihash/ihash.h (HURD_IHASH_ITERATE): Fix comparison between signed > > and unsigned integer expressions. > > Ack. > > This only fixes a warning, not a bug, right? Correct. Justus

Re: [PATCH 3/3] hurd: fix semantic of file_get_children

2014-08-31 Thread Samuel Thibault
Justus Winter, le Sun 31 Aug 2014 16:25:01 +0200, a écrit : > When first introduced as fsys_get_children, it made sense to return > the list of children using paths relative to the root of the > filesystem that was queried. Making the get_children method part of > the fsys protocol was a mistake t

Re: [PATCH 2/3] libihash: fix comparison between signed and unsigned integer

2014-08-31 Thread Samuel Thibault
Justus Winter, le Sun 31 Aug 2014 16:25:00 +0200, a écrit : > * libihash/ihash.h (HURD_IHASH_ITERATE): Fix comparison between signed > and unsigned integer expressions. Ack. This only fixes a warning, not a bug, right? > --- > libihash/ihash.h | 3 ++- > 1 file changed, 2 insertions(+), 1 delet

Re: [PATCH 1/3] trans/mtab: use setnullauth to drop privileges

2014-08-31 Thread Samuel Thibault
Justus Winter, le Sun 31 Aug 2014 16:24:59 +0200, a écrit : > * trans/mtab.c (main): Use setnullauth to drop privileges. Ack. > --- > trans/mtab.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/trans/mtab.c b/trans/mtab.c > index df03b1d..5207c1e 10064

[PATCH 2/3] libihash: fix comparison between signed and unsigned integer

2014-08-31 Thread Justus Winter
* libihash/ihash.h (HURD_IHASH_ITERATE): Fix comparison between signed and unsigned integer expressions. --- libihash/ihash.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libihash/ihash.h b/libihash/ihash.h index 345630d..849a55a 100644 --- a/libihash/ihash.h +++ b/libihas

[PATCH 3/3] hurd: fix semantic of file_get_children

2014-08-31 Thread Justus Winter
When first introduced as fsys_get_children, it made sense to return the list of children using paths relative to the root of the filesystem that was queried. Making the get_children method part of the fsys protocol was a mistake that has since been corrected in 9366d6b2. Instead of returning path

[PATCH 1/3] trans/mtab: use setnullauth to drop privileges

2014-08-31 Thread Justus Winter
* trans/mtab.c (main): Use setnullauth to drop privileges. --- trans/mtab.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/trans/mtab.c b/trans/mtab.c index df03b1d..5207c1e 100644 --- a/trans/mtab.c +++ b/trans/mtab.c @@ -27,6 +27,7 @@ #include #include

Re: Inappropriate output from /hurd/mtab

2014-08-31 Thread David Hart
Hi Justus, >> Running '/hurd/mtab /some/mountpoint/' correctly outputs the mount details. >> However trying with a non-mountpoint still emits a result: >> >> ~:/hurd/mtab /any/dir/ >> /dev/hd0s2 /any/dir ext2fs >> >> where /dev/hd0s2 is '/'. This is probably not intended behaviour. > >Why not

Re: Inappropriate output from /hurd/mtab

2014-08-31 Thread Justus Winter
Hi David :) Quoting da...@4pane.co.uk (2014-08-28 22:23:30) > Running '/hurd/mtab /some/mountpoint/' correctly outputs the mount details. > However trying with a non-mountpoint still emits a result: > > ~:/hurd/mtab /any/dir/ > /dev/hd0s2 /any/dir ext2fs > > where /dev/hd0s2 is '/'. This is p

Re: [PATCH] libdiskfs: fix reference counting of peropen objects

2014-08-31 Thread Justus Winter
Quoting Samuel Thibault (2014-08-29 23:13:08) > Justus Winter, le Fri 29 Aug 2014 11:33:44 +0200, a écrit : > > Previously, peropen objects were created with a reference count of > > zero. Therefore, if diskfs_create_protid fails, passing such an > > object to diskfs_release_peropen would lead to